linux-kernel - Re: [PATCH 1/2] Bluetooth: Remove unused hcon->remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2493f8b0-8763-4a09-ba0c-af1f73d21632@molgen.mpg.de>
Date: Wed, 12 Nov 2025 11:09:32 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Gongwei Li <13875017792@....com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Johan Hedberg <johan.hedberg@...il.com>, linux-bluetooth@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Gongwei Li <ligongwei@...inos.cn>
Subject: Re: [PATCH 1/2] Bluetooth: Remove unused hcon->remote_id

Dear Gongwei,


Thank you for your patch.

Am 12.11.25 um 10:48 schrieb Gongwei Li:
> From: Gongwei Li <ligongwei@...inos.cn>
> 
> hcon->remote_id last use was removed in 2024 by
> commit e7b02296fb40 ("Bluetooth: Remove BT_HS").
> 
> Remove it.

Please also add a Fixes: tag.

> Signed-off-by: Gongwei Li <ligongwei@...inos.cn>
> ---
>   include/net/bluetooth/hci_core.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index b8100dbfe5d7..32b1c08c8bba 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -749,7 +749,6 @@ struct hci_conn {
>   
>   	__u8		remote_cap;
>   	__u8		remote_auth;
> -	__u8		remote_id;
>   
>   	unsigned int	sent;
>   

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul