linux-kernel - RE: [PATCH net-next 2/5] net: fec: simplify the conditional preprocessor directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB8497494755B820A2D33ED39488CCA@AS8PR04MB8497.eurprd04.prod.outlook.com>
Date: Wed, 12 Nov 2025 01:53:15 +0000
From: Wei Fang <wei.fang@....com>
To: Frank Li <frank.li@....com>
CC: Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"eric@...int.com" <eric@...int.com>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 2/5] net: fec: simplify the conditional
 preprocessor directives

> > -	if (!of_machine_is_compatible("fsl,imx6ul")) {
> > -		reg_list = fec_enet_register_offset;
> > -		reg_cnt = ARRAY_SIZE(fec_enet_register_offset);
> > -	} else {
> > +
> > +#if !defined(CONFIG_M5272) || defined(CONFIG_COMPILE_TEST)
> > +	if (of_machine_is_compatible("fsl,imx6ul")) {
> 
> There are stub of_machine_is_compatible(), so needn't #ifdef here.
> 

fec_enet_register_offset_6ul is not defined when CONFIG_M5272 is
enabled, so we still need it here.

> >  		reg_list = fec_enet_register_offset_6ul;
> >  		reg_cnt = ARRAY_SIZE(fec_enet_register_offset_6ul);
> >  	}
> > -#else
> > -	/* coldfire */
> > -	static u32 *reg_list = fec_enet_register_offset;
> > -	static const u32 reg_cnt = ARRAY_SIZE(fec_enet_register_offset);
> >  #endif
> >  	ret = pm_runtime_resume_and_get(dev);
> >  	if (ret < 0)
> > --
> > 2.34.1
> >