linux-kernel - Re: [PATCH v11 2/2] Drivers: hv: Introduce mshv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7740f58-34cd-4bee-9786-8f3f6654ff3f@linux.microsoft.com>
Date: Wed, 12 Nov 2025 16:19:26 +0530
From: Naman Jain <namjain@...ux.microsoft.com>
To: Peter Zijlstra <peterz@...radead.org>,
 Michael Kelley <mhklinux@...look.com>, Paolo Bonzini <pbonzini@...hat.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>,
 Sean Christopherson <seanjc@...gle.com>,
 "K . Y . Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H . Peter Anvin"
 <hpa@...or.com>, "linux-hyperv@...r.kernel.org"
 <linux-hyperv@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "x86@...nel.org" <x86@...nel.org>,
 Mukesh Rathor <mrathor@...ux.microsoft.com>,
 Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
 Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
 Christoph Hellwig <hch@...radead.org>,
 Saurabh Sengar <ssengar@...ux.microsoft.com>,
 ALOK TIWARI <alok.a.tiwari@...cle.com>
Subject: Re: [PATCH v11 2/2] Drivers: hv: Introduce mshv_vtl driver

On 11/12/2025 3:40 PM, Peter Zijlstra wrote:
> On Wed, Nov 12, 2025 at 09:44:20AM +0000, Michael Kelley wrote:
> 
>> Thanks. If that symbol is referenced only by these few lines, I'd
>> go with something even shorter and simpler. Perhaps:
>>
>> .section		.discard.addressable,"aw"
>> .align 8
>> .type	vtl_return_sym, @object
>> .size	vtl_return_sym, 8
>> vtl_return_sym:
>> .quad	__SCK____mshv_vtl_return_hypercall
>>
>> Regardless of the choice of symbol name, add a comment about
>> mimicking __ADDRESSABLE(). That feels less messy to me, but
>> it's Naman's call.
> 
> Right, that'll work.

Thanks Michael, Peter and Paolo for your inputs.
I'll use a simpler name and add a comment to explain it.

Regards,
Naman