linux-kernel - Re: [PATCH] net/sched: act_ife: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMnQqNwkdUec0tX4cznZk8teiPRx9iBv5Ff-MeSDASj-zQ@mail.gmail.com>
Date: Wed, 12 Nov 2025 05:50:36 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Chen Ni <nichen@...as.ac.cn>
Cc: xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/sched: act_ife: convert comma to semicolon

On Wed, Nov 12, 2025 at 2:28 AM Chen Ni <nichen@...as.ac.cn> wrote:
>
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>

IIRC, Simon brought this up in the review as well...

> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>

Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal

> ---
>  net/sched/act_ife.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
> index 7c6975632fc2..1dfdda6c2d4c 100644
> --- a/net/sched/act_ife.c
> +++ b/net/sched/act_ife.c
> @@ -649,9 +649,9 @@ static int tcf_ife_dump(struct sk_buff *skb, struct tc_action *a, int bind,
>
>         memset(&opt, 0, sizeof(opt));
>
> -       opt.index = ife->tcf_index,
> -       opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref,
> -       opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind,
> +       opt.index = ife->tcf_index;
> +       opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref;
> +       opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind;
>
>         spin_lock_bh(&ife->tcf_lock);
>         opt.action = ife->tcf_action;
> --
> 2.25.1
>