linux-kernel - Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a52a7602-c7e2-4964-b9ed-3facd9bae95f@solid-run.com>
Date: Wed, 12 Nov 2025 11:43:13 +0000
From: Josua Mayer <josua@...id-run.com>
To: Frank Li <Frank.li@....com>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Neil
 Armstrong <neil.armstrong@...aro.org>, Jessica Zhang
	<jessica.zhang@....qualcomm.com>, David Airlie <airlied@...il.com>, Simona
 Vetter <simona@...ll.ch>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>, Dmitry Torokhov
	<dmitry.torokhov@...il.com>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Thierry Reding
	<thierry.reding@...il.com>, Jon Nettleton <jon@...id-run.com>, Mikhail Anikin
	<mikhail.anikin@...id-run.com>, Yazan Shhady <yazan.shhady@...id-run.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30:
 panel-common ref

Am 07.11.25 um 16:53 schrieb Frank Li:
> On Fri, Nov 07, 2025 at 12:46:09PM +0100, Josua Mayer wrote:
>> Add missing ref on panel-common.yaml for this dsi panel so that common
>> properties can be shared.
>>
>> Drop reset-gpios and backlight as they are already in panel-common.
>>
>> Switch from additionalProperties to unevaluatedProperties so that common
>> panel properties are available without repeating them in this binding.
>>
>> Notably panel-common defines the "port" property for linking panels to a
>> source - which was missing from this panel. Mark it as required.
>>
>> Signed-off-by: Josua Mayer <josua@...id-run.com>
>> ---
>>  .../devicetree/bindings/display/panel/ronbo,rb070d30.yaml  | 14 +++++---------
>>  1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
>> index 04f86e0cbac91..6940373015833 100644
>> --- a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
>> @@ -9,6 +9,9 @@ title: Ronbo RB070D30 DSI Display Panel
>>  maintainers:
>>    - Maxime Ripard <mripard@...nel.org>
>>
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
> Can you move allof after required incase add if-else branch later.

Do you mean at the very end just before unevaluatedProperties?

I have no strong opinion there but most panel bindings reference panel-common
at the very beginning, after maintainers or description.

>
> Frank
>>  properties:
>>    compatible:
>>      const: ronbo,rb070d30
>> @@ -20,10 +23,6 @@ properties:
>>      description: GPIO used for the power pin
>>      maxItems: 1
>>
>> -  reset-gpios:
>> -    description: GPIO used for the reset pin
>> -    maxItems: 1
>> -
>>    shlr-gpios:
>>      description: GPIO used for the shlr pin (horizontal flip)
>>      maxItems: 1
>> @@ -35,10 +34,6 @@ properties:
>>    vcc-lcd-supply:
>>      description: Power regulator
>>
>> -  backlight:
>> -    description: Backlight used by the panel
>> -    $ref: /schemas/types.yaml#/definitions/phandle
>> -
>>  required:
>>    - compatible
>>    - power-gpios
>> @@ -47,5 +42,6 @@ required:
>>    - shlr-gpios
>>    - updn-gpios
>>    - vcc-lcd-supply
>> +  - port
>>
>> -additionalProperties: false
>> +unevaluatedProperties: false
>>
>> --
>> 2.51.0
>>