| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202511120917.rSwJ1zUm-lkp@intel.com>
Date: Wed, 12 Nov 2025 10:04:49 +0800
From: kernel test robot <lkp@...el.com>
To: Aditya Garg <gargaditya@...ux.microsoft.com>, kys@...rosoft.com,
haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, longli@...rosoft.com,
kotaranov@...rosoft.com, horms@...nel.org,
shradhagupta@...ux.microsoft.com, ssengar@...ux.microsoft.com,
ernis@...ux.microsoft.com, dipayanroy@...ux.microsoft.com,
shirazsaleem@...rosoft.com, leon@...nel.org, mlevitsk@...hat.com,
yury.norov@...il.com, linux-hyperv@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rdma@...r.kernel.org, gargaditya@...rosoft.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Aditya Garg <gargaditya@...ux.microsoft.com>
Subject: Re: [PATCH net-next v3 2/2] net: mana: Drop TX skb on
post_work_request failure and unmap resources
Hi Aditya,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Aditya-Garg/net-mana-Handle-SKB-if-TX-SGEs-exceed-hardware-limit/20251111-162216
base: net-next/main
patch link: https://lore.kernel.org/r/1762848781-357-3-git-send-email-gargaditya%40linux.microsoft.com
patch subject: [PATCH net-next v3 2/2] net: mana: Drop TX skb on post_work_request failure and unmap resources
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20251112/202511120917.rSwJ1zUm-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 996639d6ebb86ff15a8c99b67f1c2e2117636ae7)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251112/202511120917.rSwJ1zUm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511120917.rSwJ1zUm-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/microsoft/mana/gdma_main.c:1303:23: warning: variable 'gc' set but not used [-Wunused-but-set-variable]
1303 | struct gdma_context *gc;
| ^
1 warning generated.
vim +/gc +1303 drivers/net/ethernet/microsoft/mana/gdma_main.c
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1297
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1298 int mana_gd_post_work_request(struct gdma_queue *wq,
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1299 const struct gdma_wqe_request *wqe_req,
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1300 struct gdma_posted_wqe_info *wqe_info)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1301 {
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1302 u32 client_oob_size = wqe_req->inline_oob_size;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 @1303 struct gdma_context *gc;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1304 u32 sgl_data_size;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1305 u32 max_wqe_size;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1306 u32 wqe_size;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1307 u8 *wqe_ptr;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1308
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1309 if (wqe_req->num_sge == 0)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1310 return -EINVAL;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1311
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1312 if (wq->type == GDMA_RQ) {
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1313 if (client_oob_size != 0)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1314 return -EINVAL;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1315
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1316 client_oob_size = INLINE_OOB_SMALL_SIZE;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1317
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1318 max_wqe_size = GDMA_MAX_RQE_SIZE;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1319 } else {
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1320 if (client_oob_size != INLINE_OOB_SMALL_SIZE &&
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1321 client_oob_size != INLINE_OOB_LARGE_SIZE)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1322 return -EINVAL;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1323
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1324 max_wqe_size = GDMA_MAX_SQE_SIZE;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1325 }
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1326
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1327 sgl_data_size = sizeof(struct gdma_sge) * wqe_req->num_sge;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1328 wqe_size = ALIGN(sizeof(struct gdma_wqe) + client_oob_size +
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1329 sgl_data_size, GDMA_WQE_BU_SIZE);
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1330 if (wqe_size > max_wqe_size)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1331 return -EINVAL;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1332
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1333 if (wq->monitor_avl_buf && wqe_size > mana_gd_wq_avail_space(wq)) {
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1334 gc = wq->gdma_dev->gdma_context;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1335 return -ENOSPC;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1336 }
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1337
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1338 if (wqe_info)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1339 wqe_info->wqe_size_in_bu = wqe_size / GDMA_WQE_BU_SIZE;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1340
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1341 wqe_ptr = mana_gd_get_wqe_ptr(wq, wq->head);
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1342 wqe_ptr += mana_gd_write_client_oob(wqe_req, wq->type, client_oob_size,
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1343 sgl_data_size, wqe_ptr);
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1344 if (wqe_ptr >= (u8 *)wq->queue_mem_ptr + wq->queue_size)
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1345 wqe_ptr -= wq->queue_size;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1346
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1347 mana_gd_write_sgl(wq, wqe_ptr, wqe_req);
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1348
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1349 wq->head += wqe_size / GDMA_WQE_BU_SIZE;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1350
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1351 return 0;
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1352 }
c8017f5b4856d5 Konstantin Taranov 2025-01-20 1353 EXPORT_SYMBOL_NS(mana_gd_post_work_request, "NET_MANA");
ca9c54d2d6a5ab Dexuan Cui 2021-04-16 1354
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists