Message-ID: <49471cea-d4e9-46d3-98e5-82548f32437e@freeshell.de>
Date: Wed, 12 Nov 2025 05:29:45 -0800
From: E Shattow <e@...eshell.de>
To: Hal Feng <hal.feng@...rfivetech.com>,
 Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Palmer Dabbelt
 <palmer@...belt.com>, Paul Walmsley <pjw@...nel.org>,
 Albert Ou <aou@...s.berkeley.edu>, "Rafael J . Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>,
 Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: Re: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board



On 11/11/25 23:24, Hal Feng wrote:
>> On 07.11.25 20:02, E Shattow wrote:
>> On 11/7/25 03:21, Heinrich Schuchardt wrote:
>>> On 11/7/25 12:11, E Shattow wrote:
>>>>
>>>>
>>>> On 11/7/25 01:55, Hal Feng wrote:
>>>>> VisionFive 2 Lite is a mini SBC based on the StarFive JH7110S
>>>>> industrial SoC which can run at -40~85 degrees centigrade and up to
>> 1.25GHz.
>>>>>
>>>>> Board features:
>>>>> - JH7110S SoC
>>>>> - 4/8 GiB LPDDR4 DRAM
>>>>> - AXP15060 PMIC
>>>>> - 40 pin GPIO header
>>>>> - 1x USB 3.0 host port
>>>>> - 3x USB 2.0 host port
>>>>> - 1x M.2 M-Key (size: 2242)
>>>>> - 1x MicroSD slot (optional non-removable 64GiB eMMC)
>>>>> - 1x QSPI Flash
>>>>> - 1x I2C EEPROM
>>>>> - 1x 1Gbps Ethernet port
>>>>> - SDIO-based Wi-Fi & UART-based Bluetooth
>>>>> - 1x HDMI port
>>>>> - 1x 2-lane DSI
>>>>> - 1x 2-lane CSI
>>>>>
>>>>> VisionFive 2 Lite schematics: https://doc-en.rvspace.org/
>>>>> VisionFive2Lite/PDF/VF2_LITE_V1.10_TF_20250818_SCH.pdf
>>>>> VisionFive 2 Lite Quick Start Guide: https://doc-en.rvspace.org/
>>>>> VisionFive2Lite/VisionFive2LiteQSG/index.html
>>>>> More documents: https://doc-en.rvspace.org/Doc_Center/
>>>>> visionfive_2_lite.html
>>>>>
>>>>> Changes since v1:
>>>>> - Drop patch 1 because it is applied.
>>>>> - Rename jh7110.dtsi to jh711x.dtsi.
>>>>> - Move the content of jh7110-common.dtsi to the new file
>>>>>    jh711x-common.dtsi and move opp table to jh7110-common.dtsi.
>>>>> patch 4:
>>>>> - Move the uncommon nodes to jh7110-common.dtsi instead of board
>> dts.
>>>>> patch 5:
>>>>> - Add jh7110s-common.dtsi and include it in jh7110s-starfive-
>>>>> visionfive-2-lite.dtsi.
>>>>>
>>>>> Changes since RFC:
>>>>> - Add jh7110s compatible to the generic cpufreq driver.
>>>>> - Fix the dtbs_check error by adding the missing "enable-gpios"
>>>>> property
>>>>>    in jh7110 pcie dt-bindings.
>>>>> - Rebase on the latest mainline.
>>>>> - Add VisionFive 2 Lite eMMC board device tree and add a common
>>>>> board dtsi
>>>>>    for VisionFive 2 Lite variants.
>>>>> - Add usb switch pin configuration (GPIO62).
>>>>> - Improve the commit messages.
>>>>>
>>>>> History:
>>>>> v1: https://lore.kernel.org/all/20251016080054.12484-1-
>>>>> hal.feng@...rfivetech.com/
>>>>> RFC: https://lore.kernel.org/all/20250821100930.71404-1-
>>>>> hal.feng@...rfivetech.com/
>>>>>
>>>>> Hal Feng (8):
>>>>>    dt-bindings: PCI: starfive,jh7110-pcie: Add enable-gpios property
>>>>>    dt-bindings: riscv: Add StarFive JH7110S SoC and VisionFive 2
>>>>> Lite
>>>>>      board
>>>>>    riscv: dts: starfive: Rename jh7110.dtsi to jh711x.dtsi
>>>>>    riscv: dts: starfive: Split jh7110-common.dtsi and move opp table
>>>>> to
>>>>>      it
>>>>>    riscv: dts: starfive: jh711x-common: Move out some nodes to
>>>>> jh7110
>>>>>      common dtsi
>>>>>    riscv: dts: starfive: Add common board dtsi for JH7110s and
>>>>> VisionFive
>>>>>      2 Lite variants
>>>>>    riscv: dts: starfive: Add VisionFive 2 Lite board device tree
>>>>>    riscv: dts: starfive: Add VisionFive 2 Lite eMMC board device
>>>>> tree
>>>>>
>>>>>   .../bindings/pci/starfive,jh7110-pcie.yaml    |   4 +
>>>>>   .../devicetree/bindings/riscv/starfive.yaml   |   6 +
>>>>>   arch/riscv/boot/dts/starfive/Makefile         |   3 +
>>>>>   .../boot/dts/starfive/jh7110-common.dtsi      | 653
>>>>> +----------------
>>>>>   .../boot/dts/starfive/jh7110s-common.dtsi     |  27 +
>>>>>   ...h7110s-starfive-visionfive-2-lite-emmc.dts |  22 +
>>>>>   .../jh7110s-starfive-visionfive-2-lite.dts    |  20 +
>>>>>   .../jh7110s-starfive-visionfive-2-lite.dtsi   | 126 ++++
>>>>>   .../boot/dts/starfive/jh711x-common.dtsi      | 656
>>>>> ++++++++++++++++++
>>>>>   .../dts/starfive/{jh7110.dtsi => jh711x.dtsi} |  16 -
>>>>>   10 files changed, 879 insertions(+), 654 deletions(-)
>>>>>   create mode 100644
>>>>> arch/riscv/boot/dts/starfive/jh7110s-common.dtsi
>>>>>   create mode 100644 arch/riscv/boot/dts/starfive/jh7110s-starfive-
>>>>> visionfive-2-lite-emmc.dts
>>>>>   create mode 100644 arch/riscv/boot/dts/starfive/jh7110s-starfive-
>>>>> visionfive-2-lite.dts
>>>>>   create mode 100644 arch/riscv/boot/dts/starfive/jh7110s-starfive-
>>>>> visionfive-2-lite.dtsi
>>>>>   create mode 100644 arch/riscv/boot/dts/starfive/jh711x-common.dtsi
>>>>>   rename arch/riscv/boot/dts/starfive/{jh7110.dtsi => jh711x.dtsi}
>>>>> (99%)
>>>>>
>>>>>
>>>>> base-commit: df5d79720b152e7ff058f11ed7e88d5b5c8d2a0c
>>>>
>>>> Small nit that "lite-emmc" is confusing together. In patches to
>>>> U-Boot dev mailing list the EEPROM product id is demonstrated to be with
>> "SL"
>>>> suffix when compared to VisionFive 2 (JH7110) so I suggest avoid
>>>> confusion in upstream and use for VisionFive 2 Lite (JH7110S) these
>>>> compatible names:
>>>>
>>>> starfive,visionfive-2sl-lite
>>>> starfive,visionfive-2sl-emmc
>>>>
>>>> Also filenames:
>>>>
>>>> jh7110s-starfive-visionfive-2sl-lite.dts
>>>> jh7110s-starfive-visionfive-2sl.dtsi
>>>> jh7110s-starfive-visionfive-2sl-emmc.dts
>>>>
>>>> What do you think?
>>>>
>>>
>>> This is a serial number for the Lite board:
>>> VF7110SL-2310-D002E000-xxxxxxxx
>>>
>>> Here E000 encodes that we have no eMMC.
>>>
>>> The S is part of 7110S which we already have in 'jh7110s'. And the L
>>> is already decoded as 'lite' in this patch series. Duplicating this
>>> information as 'sl' as you suggested provides no benefit.
>>
>> The convention in dts file names is CPU model first so that will be redundant
>> or not redundant depending on the name of the product anyway; whether it
>> is redundant or not is not the driver of whether it is confusing to have
>> contradictory terminology in the product name and compatible names and dts
>> filenames.
>>
>>>
>>> Let's just stick with Hal's suggestion.
>>>
>>> Best regards
>>>
>>> Heinrich
>>
>> The "lite" product name in similar products refers to non-populated emmc
>> replaced by sd card, so there is benefit to choose a more concise name that is
>> not confusing.
>>
>> I did consider suggesting:
>>
>> jh7110s-starfive-visionfive-2-lite.dts
>> jh7110s-starfive-visionfive-2.dtsi
>> jh7110s-starfive-visionfive-2-emmc.dts
>>
>> but this is a loss of information and does not help readability. By extension
>> we're not duplicating information to be more descriptive with the product
>> name. Sure I'd go along with:
>>
>> jh7110s-starfive-visionfive-2-lite-card.dts
>> jh7110s-starfive-visionfive-2-lite.dtsi
>> jh7110s-starfive-visionfive-2-lite-emmc.dts
>>
>> But my suggestion remains:
>>
>> jh7110s-starfive-visionfive-2sl-lite.dts
>> jh7110s-starfive-visionfive-2sl.dtsi
>> jh7110s-starfive-visionfive-2sl-emmc.dts
>>
>> for the reason that it's very clearly not the "non-emmc" version of the
>> VisionFive 2. You can't mistake it if done the way I am suggesting.
> 
> VisionFive 2 Lite is not the "non-emmc" version of the VisionFive 2. "Lite" here means the
> light version and smaller size. I think we can't apply the name definition of another product
> to here. VisionFive 2 Lite is the official name of this product and the name we call in our
> official documents.
> 
> Best regards,
> Hal

Okay then LGTM, for the series,

Reviewed-by: E Shattow <e@...eshell.de>

Powered by blists - more mailing lists