linux-kernel - Re: [PATCH v2 0/2] Enable FPGA Manager support for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b9796e9-414d-4af3-bcf0-40eda370ec31@kernel.org>
Date: Thu, 13 Nov 2025 14:41:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Romli, Khairul Anuar" <khairul.anuar.romli@...era.com>,
 Xu Yilun <yilun.xu@...ux.intel.com>
Cc: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
 Tom Rix <trix@...hat.com>, Dinh Nguyen <dinguyen@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, "Rao, Mahesh" <mahesh.rao@...era.com>,
 "Ng, Adrian Ho Yin" <adrian.ho.yin.ng@...era.com>,
 "Rabara, Niravkumar Laxmidas" <nirav.rabara@...era.com>,
 "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] Enable FPGA Manager support for Agilex5

On 13/11/2025 10:38, Romli, Khairul Anuar wrote:
> On 13/11/2025 5:10 pm, Krzysztof Kozlowski wrote:
>> On 13/11/2025 10:07, Romli, Khairul Anuar wrote:
>>> On 13/11/2025 3:13 pm, Krzysztof Kozlowski wrote:
>>>> On 13/11/2025 07:01, Xu Yilun wrote:
>>>>> On Thu, Nov 13, 2025 at 12:43:54PM +0800, Khairul Anuar Romli wrote:
>>>>>> This patch series adds device tree bindings, driver support, and DTS
>>>>>> updates to enable FPGA Manager functionality for Intel Agilex5 SoC.
>>>>>>
>>>>>> These changes are intended to enable FPGA programming and management
>>>>>> capabilities on Agilex5-based platforms.
>>>>>>
>>>>>> ---
>>>>>> Notes:
>>>>>> Patch #3 depends on  "arm64: dts: intel: Add Agilex5 SVC node with memory
>>>>>
>>>>> There is no patch #3 now. Should be Patch #2 ?
>>>>>
>>>>>> region" from
>>>>>> https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/
>>>>>>
>>>>>> This patch series is applied on socfpga maintainer's tree
>>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19
>>>>>
>>>>> Given that, @Dinh Nguyen could you take the series if you are good?
>>>>
>>>> This was never tested, so series cannot be taken.
>>>>
>>>> NAK, Altera should test the code BEFORE sending it to upstream, not
>>>> after we say it was not tested.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> If you are referring to the code being tested on the Agilex5, it was
>>> tested. I even take the measure to add the debug print the in init to
>>> see if the fallback is working, which it did.
>>>
>>> Of course I took clock manager patch from Dinh's clock manager driver
>>> for Agilex5 have local defconfig instead of using default defconfig for
>>> testing the code.
>>>
>>> https://lore.kernel.org/all/9326ee66cb8e33c0fe83a24e9a1effc8da252ff2.1760396607.git.khairul.anuar.romli@altera.com/
>>>
>>> Are you referring to different kind of test?
>>
>> Yes, test by tools, because you certainly do not want to engage
>> reviewers if computers do the job fine.
>>
>> see any DT talk (there where like four last years!) or
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>>
>> Best regards,
>> Krzysztof
> 
> Thanks, I can see the error with make -j48 CHECK_DTBS=y
> DT_SCHEMA_FILES=intel,stratix10-soc-fpga-mgr.yaml
> intel/socfpga_agilex5_socdk.dtb;
> 
> If i revert back without adding "intel,agilex-soc-fpga-mgr"", the tool
> is able to pass without any issue. But we need the driver entry to make
> it able to load as it compare the entry from dts and the compatible
> entry in the driver.
> 
> Should we add back the entry in the driver like in the v1? Or, shall we
> defer the driver changes for now?

You ask now about basics of DT, so sorry but doing homework is your
task. Maybe the beginners DTS talk from this year's OSSEU will be
helpful here. Or one of many other resources...

Best regards,
Krzysztof