linux-kernel - Re: [PATCH net] net: dsa: hellcreek: fix missing error handling in LED registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d66a428d-5d11-4656-92c7-eec351a1cc98@lunn.ch>
Date: Thu, 13 Nov 2025 15:08:18 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>
Cc: Kurt Kanzenbach <kurt@...utronix.de>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Richard Cochran <richardcochran@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net] net: dsa: hellcreek: fix missing error handling in
 LED registration

On Thu, Nov 13, 2025 at 04:57:44PM +0300, Pavel Zhigulin wrote:
> The LED setup routine registered both led_sync_good
> and led_is_gm devices without checking the return
> values of led_classdev_register(). If either registration
> failed, the function continued silently, leaving the
> driver in a partially-initialized state and leaking
> a registered LED classdev.
> 
> Add proper error handling
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Does it say anything about leaking leds?

> Fixes: 7d9ee2e8ff15 ("net: dsa: hellcreek: Add PTP status LEDs")
> Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew