linux-kernel - [PATCH v3] ASoC: Intel: avs: Replace snprintf() with scnprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251113142637.259737-2-hariconscious@gmail.com>
Date: Thu, 13 Nov 2025 19:56:38 +0530
From: hariconscious@...il.com
To: cezary.rojewski@...el.com,
	liam.r.girdwood@...ux.intel.com,
	peter.ujfalusi@...ux.intel.com,
	yung-chuan.liao@...ux.intel.com,
	ranjani.sridharan@...ux.intel.com,
	kai.vehmanen@...ux.intel.com,
	pierre-louis.bossart@...ux.dev,
	broonie@...nel.org
Cc: perex@...ex.cz,
	tiwai@...e.com,
	amadeuszx.slawinski@...ux.intel.com,
	sakari.ailus@...ux.intel.com,
	khalid@...nel.org,
	shuah@...nel.org,
	david.hunter.linux@...il.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	HariKrishna Sagala <hariconscious@...il.com>
Subject: [PATCH v3] ASoC: Intel: avs: Replace snprintf() with scnprintf()

From: HariKrishna Sagala <hariconscious@...il.com>

snprintf() as defined by the C99 standard,returns the
number of characters that *would have been* written if
enough space were available.Use scnprintf() that returns
the actual number of characters written.

Link: https://github.com/KSPP/linux/issues/105
Signed-off-by: HariKrishna Sagala <hariconscious@...il.com>
---
Thank you all for the valuable feedback and suggestions.

This patch updates usage of snprintf() with scnprintf(). 
As in accordance with the C99 standard, snprintf() returns
the number of characters that would have been written if
enough space were available.With scnprintf(),the return value
reflects the actual number of characters written.
Change log:
V3:
Dropped the Fixes, stable tag & updated the commit message.
scnprintf doesn't return the negative values as per the contract.
Hence removed the check of ret < 0 as it is unreachable.
https://www.kernel.org/doc/html/latest/core-api/kernel-api.html#c.scnprintf
V2:
https://lore.kernel.org/all/20251112181851.13450-1-hariconscious@gmail.com/
V1:
https://lore.kernel.org/all/20251112120235.54328-2-hariconscious@gmail.com/

 sound/soc/intel/avs/debugfs.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/sound/soc/intel/avs/debugfs.c b/sound/soc/intel/avs/debugfs.c
index 3534de46f9e4..d224b25323be 100644
--- a/sound/soc/intel/avs/debugfs.c
+++ b/sound/soc/intel/avs/debugfs.c
@@ -119,16 +119,13 @@ static ssize_t probe_points_read(struct file *file, char __user *to, size_t coun
 	}

 	for (i = 0; i < num_desc; i++) {
-		ret = snprintf(buf + len, PAGE_SIZE - len,
-			       "Id: %#010x  Purpose: %d  Node id: %#x\n",
-			       desc[i].id.value, desc[i].purpose, desc[i].node_id.val);
-		if (ret < 0)
-			goto free_desc;
+		ret = scnprintf(buf + len, PAGE_SIZE - len,
+				"Id: %#010x  Purpose: %d  Node id: %#x\n",
+				desc[i].id.value, desc[i].purpose, desc[i].node_id.val);
 		len += ret;
 	}

 	ret = simple_read_from_buffer(to, count, ppos, buf, len);
-free_desc:
 	kfree(desc);
 exit:
 	kfree(buf);

base-commit: 24172e0d79900908cf5ebf366600616d29c9b417
-- 
2.43.0