linux-kernel - Re: [PATCH -next] reset: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdc04e4a-3930-41ca-9147-ce5bbf2d41ac@paulmck-laptop>
Date: Thu, 13 Nov 2025 06:49:38 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: bartosz.golaszewski@...aro.org, linux-kernel@...r.kernel.org,
	sfr@...b.auug.org.au, bigeasy@...utronix.de
Subject: Re: [PATCH -next] reset: Remove unused variables

On Thu, Nov 13, 2025 at 10:51:50AM +0100, Philipp Zabel wrote:
> On Mi, 2025-11-12 at 12:59 -0800, Paul E. McKenney wrote:
> > Neither reset_lookup_mutex nor reset_lookup_list are used anymore, which
> > results in build errors, so remove them.  It would be best if this were
> > to be folded into commit 205b261463ff ("reset: remove legacy reset lookup
> > code"), the better for bisection efforts.
> > 
> > Reproduce on armv8 with:
> > 
> > tools/testing/selftests/rcutorture/bin/torture.sh --duration 10 --do-none --do-rt
> > 
> > Fixes: 205b261463ff ("reset: remove legacy reset lookup code") # -next
> > Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
> > Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> > Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> > 
> > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > index 22f67fc77ae5..93575d5064a5 100644
> > --- a/drivers/reset/core.c
> > +++ b/drivers/reset/core.c
> > @@ -25,9 +25,6 @@
> >  static DEFINE_MUTEX(reset_list_mutex);
> >  static LIST_HEAD(reset_controller_list);
> >  
> > -static DEFINE_MUTEX(reset_lookup_mutex);
> > -static LIST_HEAD(reset_lookup_list);
> > -
> >  /* Protects reset_gpio_lookup_list */
> >  static DEFINE_MUTEX(reset_gpio_lookup_mutex);
> >  static LIST_HEAD(reset_gpio_lookup_list);
> 
> Thank you, just applied to reset/next for now:
> 
> [1/1] reset: Remove unused variables
>       https://git.pengutronix.de/cgit/pza/linux/commit/?id=3754bc97926e
> 
> I'll rebase this branch and squash this fix into 205b261463ff before
> sending a pull request. There's also the 25d4d4604d01 / f5c877fb74f4
> patch / revert pair that I should drop.

Thank you both!

							Thanx, Paul