linux-kernel - Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ee3c7a6-65cc-4d67-9a4d-5b9b09e7908e@linux.intel.com>
Date: Thu, 13 Nov 2025 16:22:40 +0100
From: "Falkowski, Maciej" <maciej.falkowski@...ux.intel.com>
To: Lizhi Hou <lizhi.hou@....com>, ogabbay@...nel.org,
 quic_jhugo@...cinc.com, dri-devel@...ts.freedesktop.org
Cc: linux-kernel@...r.kernel.org, max.zhen@....com, sonal.santan@....com,
 mario.limonciello@....com
Subject: Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during
 channel creation

Reviewed-by: Maciej Falkowski <maciej.falkowski@...ux.intel.com>

On 11/7/2025 7:11 PM, Lizhi Hou wrote:
> The mailbox interrupt register is not always cleared when a mailbox channel
> is created. This can leave stale interrupt states from previous operations.
>
> Fix this by explicitly clearing the interrupt register in the mailbox
> channel creation function.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
> ---
>   drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 24258dcc18eb..858df97cd3fb 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
>   	}
>   
>   	mb_chann->bad_state = false;
> +	mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
>   
>   	MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
>   	return mb_chann;