linux-kernel - Re: [PATCH 2/9] PCI/IOV: Adjust ->barsz[] when changing BAR size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe9bd3af-51f6-c1af-9cdc-c78aee7aaef9@linux.intel.com>
Date: Thu, 13 Nov 2025 18:35:26 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bjorn Helgaas <helgaas@...nel.org>
cc: Alex Bennée <alex.bennee@...aro.org>, 
    Simon Richter <Simon.Richter@...yros.de>, 
    Lucas De Marchi <lucas.demarchi@...el.com>, 
    Alex Deucher <alexander.deucher@....com>, amd-gfx@...ts.freedesktop.org, 
    Bjorn Helgaas <bhelgaas@...gle.com>, David Airlie <airlied@...il.com>, 
    dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org, 
    intel-xe@...ts.freedesktop.org, Jani Nikula <jani.nikula@...ux.intel.com>, 
    Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, 
    linux-pci@...r.kernel.org, Rodrigo Vivi <rodrigo.vivi@...el.com>, 
    Simona Vetter <simona@...ll.ch>, Tvrtko Ursulin <tursulin@...ulin.net>, 
    Christian König <christian.koenig@....com>, 
    Thomas Hellström <thomas.hellstrom@...ux.intel.com>, 
    Michał Winiarski <michal.winiarski@...el.com>, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/9] PCI/IOV: Adjust ->barsz[] when changing BAR size

On Thu, 13 Nov 2025, Bjorn Helgaas wrote:

> On Tue, Oct 28, 2025 at 07:35:44PM +0200, Ilpo Järvinen wrote:
> > pci_rebar_set_size() adjusts BAR size for both normal and IOV BARs. The
> > struct pci_srvio keeps a cached copy of BAR size in unit of
> > resource_size_t in ->barsz[] ...
> 
> Nit: s/pci_srvio/pci/sriov/  (fixed locally, FYI in case you post a v2)

I just posted v2 without seeing this first. :-(

I seem to never learn to type those letters in the correct order, I don't 
know why I always keep typing them wrong.

> I'm not sure what "unit of resource_size_t" adds here, maybe could be
> removed to just say this?
> 
>   struct pci_srvio keeps a cached copy of BAR size in ->barsz[] ...

Seems okay with me. I just had it there to differentiate from "BAR size" 
which happens to often be the format directly compatible with field in the 
capability.

-- 
 i.