linux-kernel - Re: [PATCH] dmaengine: sh: rz-dmac: Fix rz_dmac_terminate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVP3xOGa4gj6LRBU1fdGPbihAayGF8xUCCZjJctyR-DOQ@mail.gmail.com>
Date: Thu, 13 Nov 2025 17:23:00 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Vinod Koul <vkoul@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, dmaengine@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.au@...il.com>, 
	linux-renesas-soc@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] dmaengine: sh: rz-dmac: Fix rz_dmac_terminate_all()

Hi Biju,

Thanks for your patch!

On Thu, 6 Nov 2025 at 13:53, Biju Das <biju.das.jz@...renesas.com> wrote:
> After audio full duplex testing, playing the recorded file contains a few
> playback frames for the first time. The rz_dmac_terminate_all() does not

... frames from the previous time?

> reset all the hardware descriptors queued previously, leading to the wrong
> descriptor being picked up during the next DMA transfer. Fix this issue by
> resetting all descriptor headers for a channel in rz_dmac_terminate_all()
> as rz_dmac_lmdesc_recycle() points to the proper descriptor header filled
> by the rz_dmac_prepare_descs_for_slave_sg().
>
> Cc: stable@...nel.org
> Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC")
> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>

The code change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds