linux-kernel - Re: [PATCH] arm64: dts: imx8qm-mek: fix mux-controller select/enable-gpios polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRYHLAVjcr4jcpJG@lizhi-Precision-Tower-5810>
Date: Thu, 13 Nov 2025 11:28:28 -0500
From: Frank Li <Frank.li@....com>
To: Xu Yang <xu.yang_2@....com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, jun.li@....com, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8qm-mek: fix mux-controller
 select/enable-gpios polarity

On Thu, Nov 13, 2025 at 07:14:44PM +0800, Xu Yang wrote:
> According to the board design, set SEL to high means flipped
> connection (TX2/RX2). And the TCPM will output logical 1 if it needs
> flipped connection. So switch to active high for select-gpios.
> The EN pin on mux chip is low active, so switch to active low for
> enable-gpios too.
>
> Fixes: b237975b2cd5 ("arm64: dts: imx8qm-mek: add usb 3.0 and related type C nodes")
> Cc: stable@...r.kernel.org
> Reviewed-by: Jun Li <jun.li@....com>
> Signed-off-by: Xu Yang <xu.yang_2@....com>
> ---

Reviewed-by: Frank Li <Frank.Li@....com>

>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> index 202d5c67ac40..9c0b6b8d6459 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> @@ -217,8 +217,8 @@ mux-controller {
>  		compatible = "nxp,cbdtu02043", "gpio-sbu-mux";
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_typec_mux>;
> -		select-gpios = <&lsio_gpio4 6 GPIO_ACTIVE_LOW>;
> -		enable-gpios = <&lsio_gpio4 19 GPIO_ACTIVE_HIGH>;
> +		select-gpios = <&lsio_gpio4 6 GPIO_ACTIVE_HIGH>;
> +		enable-gpios = <&lsio_gpio4 19 GPIO_ACTIVE_LOW>;
>  		orientation-switch;
>
>  		port {
> --
> 2.34.1
>