linux-kernel - Re: [PATCH v4] mmc: sdhci-msm: Enable ICE support for non-cmdq eMMC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251113173500.GE1792@sol>
Date: Thu, 13 Nov 2025 09:35:00 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Md Sadre Alam <quic_mdalam@...cinc.com>
Cc: adrian.hunter@...el.com, ulf.hansson@...aro.org,
	linux-mmc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, quic_varada@...cinc.com
Subject: Re: [PATCH v4] mmc: sdhci-msm: Enable ICE support for non-cmdq eMMC
 devices

On Thu, Nov 13, 2025 at 12:41:28PM +0530, Md Sadre Alam wrote:
> > > +	if (mrq->crypto_ctx) {
> > > +		if (!msm_host->ice_init_done) {
> > > +			sdhci_msm_non_cqe_ice_init(host);
> > > +			msm_host->ice_init_done = true;
> > > +		}
> > 
> > This means sdhci_msm_ice_enable() is called only once per host
> > controller.  It looks like the existing call to sdhci_msm_ice_enable()
> > happens each time after the host controller is resumed.  So there seems
> > to be an inconsistency there.  Which way is correct?
> Thank you for highlighting this. After revisiting the code paths, I believe
> the behavior is consistent across both CQE and non-CQE modes.
> ICE is re-enabled on every resume via the common sdhci_msm_runtime_resume()
> → sdhci_msm_ice_resume() → qcom_ice_resume() → sdhci_msm_ice_enable() path.
> The ice_init_done flag only governs one-time initialization in
> sdhci_msm_ice_cfg() and doesn’t interfere with the resume logic.
> 
> In summary:
> CQE mode: ICE enabled during sdhci_msm_cqe_enable() + every resume
> Non-CQE mode: ICE enabled on first crypto request + every resume

I was looking at sdhci_msm_cqe_enable().  Based on the caller, it seems
to be a per-resume thing too.  So it doesn't seem consistent.

- Eric