linux-kernel - Re: [PATCH net-next] sctp: Remove unused declaration sctp_auth_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251113171906.GB1792@sol>
Date: Thu, 13 Nov 2025 09:19:06 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: marcelo.leitner@...il.com, lucien.xin@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, linux-sctp@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] sctp: Remove unused declaration
 sctp_auth_init_hmacs()

On Thu, Nov 13, 2025 at 07:45:01PM +0800, Yue Haibing wrote:
> Commit bf40785fa437 ("sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk
> authentication") removed the implementation but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  include/net/sctp/auth.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/net/sctp/auth.h b/include/net/sctp/auth.h
> index 3d5879e08e78..6f2cd562b1de 100644
> --- a/include/net/sctp/auth.h
> +++ b/include/net/sctp/auth.h
> @@ -72,7 +72,6 @@ struct sctp_shared_key *sctp_auth_get_shkey(
>  int sctp_auth_asoc_copy_shkeys(const struct sctp_endpoint *ep,
>  				struct sctp_association *asoc,
>  				gfp_t gfp);
> -int sctp_auth_init_hmacs(struct sctp_endpoint *ep, gfp_t gfp);
>  const struct sctp_hmac *sctp_auth_get_hmac(__u16 hmac_id);
>  const struct sctp_hmac *
>  sctp_auth_asoc_get_hmac(const struct sctp_association *asoc);

Reviewed-by: Eric Biggers <ebiggers@...nel.org>

- Eric