linux-kernel - Re: [PATCH] crypto: sa2ul: Add error handling for DMA metadata retrieval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202511140226.Czi6K1Kj-lkp@intel.com>
Date: Fri, 14 Nov 2025 02:54:39 +0800
From: kernel test robot <lkp@...el.com>
To: Haotian Zhang <vulab@...as.ac.cn>, herbert@...dor.apana.org.au,
	davem@...emloft.net
Cc: oe-kbuild-all@...ts.linux.dev, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, Haotian Zhang <vulab@...as.ac.cn>
Subject: Re: [PATCH] crypto: sa2ul: Add error handling for DMA metadata
 retrieval

Hi Haotian,

kernel test robot noticed the following build errors:

[auto build test ERROR on herbert-cryptodev-2.6/master]
[also build test ERROR on herbert-crypto-2.6/master linus/master v6.18-rc5 next-20251113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haotian-Zhang/crypto-sa2ul-Add-error-handling-for-DMA-metadata-retrieval/20251113-155200
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/20251113075104.1396-1-vulab%40iscas.ac.cn
patch subject: [PATCH] crypto: sa2ul: Add error handling for DMA metadata retrieval
config: microblaze-randconfig-r073-20251113 (https://download.01.org/0day-ci/archive/20251114/202511140226.Czi6K1Kj-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511140226.Czi6K1Kj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511140226.Czi6K1Kj-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/crypto/sa2ul.c: In function 'sa_sha_dma_in_callback':
>> drivers/crypto/sa2ul.c:1387:29: error: passing argument 1 of 'skcipher_request_complete' from incompatible pointer type [-Werror=incompatible-pointer-types]
      skcipher_request_complete(req, PTR_ERR(mdptr));
                                ^~~
   In file included from drivers/crypto/sa2ul.c:28:
   include/crypto/internal/skcipher.h:94:71: note: expected 'struct skcipher_request *' but argument is of type 'struct ahash_request *'
    static inline void skcipher_request_complete(struct skcipher_request *req, int err)
                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
   drivers/crypto/sa2ul.c: In function 'sa_aead_dma_in_callback':
   drivers/crypto/sa2ul.c:1705:29: error: passing argument 1 of 'skcipher_request_complete' from incompatible pointer type [-Werror=incompatible-pointer-types]
      skcipher_request_complete(req, PTR_ERR(mdptr));
                                ^~~
   In file included from drivers/crypto/sa2ul.c:28:
   include/crypto/internal/skcipher.h:94:71: note: expected 'struct skcipher_request *' but argument is of type 'struct aead_request *'
    static inline void skcipher_request_complete(struct skcipher_request *req, int err)
                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
   cc1: some warnings being treated as errors


vim +/skcipher_request_complete +1387 drivers/crypto/sa2ul.c

  1365	
  1366	static void sa_sha_dma_in_callback(void *data)
  1367	{
  1368		struct sa_rx_data *rxd = data;
  1369		struct ahash_request *req;
  1370		struct crypto_ahash *tfm;
  1371		unsigned int authsize;
  1372		int i;
  1373		size_t ml, pl;
  1374		u32 *result;
  1375		__be32 *mdptr;
  1376	
  1377		sa_sync_from_device(rxd);
  1378		req = container_of(rxd->req, struct ahash_request, base);
  1379		tfm = crypto_ahash_reqtfm(req);
  1380		authsize = crypto_ahash_digestsize(tfm);
  1381	
  1382		mdptr = (__be32 *)dmaengine_desc_get_metadata_ptr(rxd->tx_in, &pl, &ml);
  1383		if (IS_ERR(mdptr)) {
  1384			dev_err(rxd->ddev, "Failed to get SHA RX metadata pointer: %ld\n",
  1385				PTR_ERR(mdptr));
  1386			sa_free_sa_rx_data(rxd);
> 1387			skcipher_request_complete(req, PTR_ERR(mdptr));
  1388			return;
  1389		}
  1390	
  1391		result = (u32 *)req->result;
  1392	
  1393		for (i = 0; i < (authsize / 4); i++)
  1394			result[i] = be32_to_cpu(mdptr[i + 4]);
  1395	
  1396		sa_free_sa_rx_data(rxd);
  1397	
  1398		ahash_request_complete(req, 0);
  1399	}
  1400	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki