linux-kernel - Re: [PATCH net-next 1/2] dt-bindings: net: pcs: renesas,rzn1-miic: Add renesas,miic-phylink-active-low property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8s39qSBLsbEkGJTjg7cLPHuKTFTONLCLh39KO30Y+1_kg@mail.gmail.com>
Date: Thu, 13 Nov 2025 19:10:22 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Clément Léger <clement.leger@...tlin.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiner Kallweit <hkallweit1@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Magnus Damm <magnus.damm@...il.com>, linux-renesas-soc@...r.kernel.org, 
	netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: pcs: renesas,rzn1-miic:
 Add renesas,miic-phylink-active-low property

Hi Russell,

On Thu, Nov 13, 2025 at 7:05 PM Lad, Prabhakar
<prabhakar.csengg@...il.com> wrote:
>
> Hi Russell,
>
> On Thu, Nov 13, 2025 at 3:58 PM Russell King (Oracle)
> <linux@...linux.org.uk> wrote:
> >
> > On Thu, Nov 13, 2025 at 02:45:18PM +0000, Lad, Prabhakar wrote:
> > > Hi Wolfram,
> > >
> > > On Wed, Nov 12, 2025 at 8:40 PM Wolfram Sang
> > > <wsa+renesas@...g-engineering.com> wrote:
> > > >
> > > > Hi Prabhakar,
> > > >
> > > > > Add the boolean DT property `renesas,miic-phylink-active-low` to the RZN1
> > > >
> > > > Hmm, we already have "renesas,ether-link-active-low" in
> > > > renesas,ether.yaml and renesas,etheravb.yaml. Can't we reuse that?
> > > >
> > > On the RZ/N1x we have the below architecture
> > >
> > >                                                       +----> Ethernet Switch
> > >                                                       |           |
> > >                                                       |           v
> > >     MII Converter ----------------------+      GMAC (Synopsys IP)
> > >                                                       |
> > >                                                       +----> EtherCAT
> > > Slave Controller
> > >                                                       |
> > >                                                       +----> SERCOS
> > > Controller
> >
> > I'm not sure that diagram has come out correctly. If you're going to
> > draw diagrams, make sure you do it using a fixed-width font. To me,
> > it looks like the MII Converter is bolted to GMAC and only has one
> > connection, and the GMAC has what seems to be maybe five connections.
> >
> Sorry when typing the diagram the mail client showed the diagram OK
> but when sent everything was messed up. Ive represented now in a
> different way.
>
>                                     +-----------------------+
>                                     |   MII Converter     |
>                                     +-----------+-----------+
>                                                     |
>            +-----------------------------------------+-------------------------------------------+
>             |                                                  |
>                                                |
>             v                                                 v
>                                              v
>  +---------------------+
> +---------------------------+
> +------------------------------+
>  | Ethernet Switch  |                   |  EtherCAT Slave      |
>             |  SERCOS Controller   |
>  +---------+------------+                  |  Controller
> |                   +------------------------------+
>                |                                  +---------------------------+
>                |
>                v
>   +-------------------------+
>  |  GMAC (Synopsys  |
>  |       IP)                     |
>  +--------------------------+
>
Looks like this was messed up too, Ive pasted the diagram here now
https://gist.github.com/prabhakarlad/9549df941eaced5b06efc572ff6c82b5

Sorry for the noise.

Cheers,
Prabhakar