linux-kernel - Re: [PATCH net] net: mlxsw: linecards: fix missing error check in mlxsw_linecard_devlink_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRYuQpOqe6FOM7CI@shredder>
Date: Thu, 13 Nov 2025 21:15:14 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>
Cc: Petr Machata <petrm@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net] net: mlxsw: linecards: fix missing error check in
 mlxsw_linecard_devlink_info_get()

On Thu, Nov 13, 2025 at 07:19:21PM +0300, Pavel Zhigulin wrote:
> The call to devlink_info_version_fixed_put() in
> mlxsw_linecard_devlink_info_get() did not check for errors,
> although it is checked everywhere in the code.
> 
> Add missed 'err' check to the mlxsw_linecard_devlink_info_get()
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 3fc0c51905fb ("mlxsw: core_linecards: Expose device PSID over device info")
> Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>