linux-kernel - Re: [PATCH v2] watchdog: wdat_wdt: Fix ACPI table leak in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89e111c7-868f-4476-8a7d-98936674dee2@roeck-us.net>
Date: Thu, 13 Nov 2025 11:31:41 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] watchdog: wdat_wdt: Fix ACPI table leak in probe
 function

On Thu, Nov 13, 2025 at 10:30:32AM +0800, Haotian Zhang wrote:
> wdat_wdt_probe() calls acpi_get_table() to obtain the WDAT ACPI table but
> never calls acpi_put_table() on any paths. This causes a permanent ACPI
> table memory leak.
> 
> Add a single cleanup path which calls acpi_put_table() to ensure
> the ACPI table is always released.
> 
> Fixes: 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware watchdog")
> Suggested-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>