linux-kernel - Re: [PATCH 2/3] drm/virtio: honor blob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43c1ee1b-a9be-489b-82f6-0f4d24a409d5@collabora.com>
Date: Thu, 13 Nov 2025 05:20:43 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Sergio Lopez <slp@...hat.com>, David Airlie <airlied@...hat.com>,
 Gerd Hoffmann <kraxel@...hat.com>,
 Gurchetan Singh <gurchetansingh@...omium.org>, Chia-I Wu
 <olvaffe@...il.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Simona Vetter <simona@...ll.ch>, "Michael S. Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 dri-devel@...ts.freedesktop.org, virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drm/virtio: honor blob_alignment requirements

On 11/10/25 15:52, Sergio Lopez wrote:
> @@ -216,8 +216,14 @@ int virtio_gpu_vram_create(struct virtio_gpu_device *vgdev,
>  		return ret;
>  	}
>  
> -	virtio_gpu_cmd_resource_create_blob(vgdev, &vram->base, params, NULL,
> -					    0);
> +	ret = virtio_gpu_cmd_resource_create_blob(vgdev, &vram->base, params,
> +						  NULL, 0);
> +	if (ret) {
> +		drm_gem_free_mmap_offset(obj);
> +		kfree(vram);
> +		return ret;
> +	}

virtio_gpu_cleanup_object() shall be used to free obj, otherwise
resource_ida and etc is leaked

-- 
Best regards,
Dmitry