linux-kernel - Re: [PATCH v3 6/9] x86/entry/vdso: include GNU_PROPERTY and GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2d39a78-a66c-4846-b07a-b7cd5a85d00b@zytor.com>
Date: Thu, 13 Nov 2025 13:13:50 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: Andrew Cooper <andrew.cooper3@...rix.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        "Theodore Ts'o" <tytso@....edu>,
        Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
        Xin Li <xin@...or.com>, Andy Lutomirski <luto@...nel.org>,
        Ard Biesheuvel <ardb@...nel.org>, Borislav Petkov <bp@...en8.de>,
        Brian Gerst <brgerst@...il.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>, James Morse <james.morse@....com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Josh Poimboeuf <jpoimboe@...nel.org>, Kees Cook <kees@...nel.org>,
        Nam Cao <namcao@...utronix.de>, Oleg Nesterov <oleg@...hat.com>,
        Perry Yuan <perry.yuan@....com>, Thomas Gleixner <tglx@...utronix.de>,
        Thomas Huth <thuth@...hat.com>, Uros Bizjak <ubizjak@...il.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-sgx@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v3 6/9] x86/entry/vdso: include GNU_PROPERTY and GNU_STACK
 PHDRs

On 2025-11-13 11:09, Andrew Cooper wrote:
> 
> Almost all of these hunks look to be whitespace changes only.  Was that
> intentional?  It certainly makes it harder to read.
> 

It is intentional; although it adds to the patch it tidies up the file itself.

>>  	.altinstructions	: { *(.altinstructions) }	:text
>>  	.altinstr_replacement	: { *(.altinstr_replacement) }	:text
>> @@ -87,15 +84,23 @@ SECTIONS
>>   * Very old versions of ld do not recognize this name token; use the constant.
>>   */
>>  #define PT_GNU_EH_FRAME	0x6474e550
>> +#define PT_GNU_STACK	0x6474e551
>> +#define PT_GNU_PROPERTY	0x6474e553
>>  
>>  /*
>>   * We must supply the ELF program headers explicitly to get just one
>>   * PT_LOAD segment, and set the flags explicitly to make segments read-only.
>> - */
>> +*/
> 
> This looks like it wants undoing too.

OK, fair.

> That said, I do strongly agree with the reasoning behind this patch.

Thanks.

	-hpa