| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<SJ0PR11MB5896D2F9DAC35FF8ADB29087C3CDA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Thu, 13 Nov 2025 22:34:36 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Corey Minyard
<corey@...yard.net>, Christian König
<christian.koenig@....com>, "Dr. David Alan Gilbert" <linux@...blig.org>,
Alex Deucher <alexander.deucher@....com>, Thomas Zimmermann
<tzimmermann@...e.de>, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
Rob Clark <robin.clark@....qualcomm.com>, Matthew Brost
<matthew.brost@...el.com>, Ulf Hansson <ulf.hansson@...aro.org>, Aleksandr
Loktionov <aleksandr.loktionov@...el.com>, Vitaly Lifshits
<vitaly.lifshits@...el.com>, Manivannan Sadhasivam <mani@...nel.org>, Niklas
Cassel <cassel@...nel.org>, Calvin Owens <calvin@...nvd.org>, Vadim Fedorenko
<vadim.fedorenko@...ux.dev>, Sagi Maimon <maimon.sagi@...il.com>, "Martin K.
Petersen" <martin.petersen@...cle.com>, Hans Verkuil
<hverkuil+cisco@...nel.org>, Casey Schaufler <casey@...aufler-ca.com>, Steven
Rostedt <rostedt@...dmis.org>, Petr Mladek <pmladek@...e.com>, Viacheslav
Dubeyko <Slava.Dubeyko@....com>, Max Kellermann <max.kellermann@...os.com>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"openipmi-developer@...ts.sourceforge.net"
<openipmi-developer@...ts.sourceforge.net>, "linux-media@...r.kernel.org"
<linux-media@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
<dri-devel@...ts.freedesktop.org>, "linaro-mm-sig@...ts.linaro.org"
<linaro-mm-sig@...ts.linaro.org>, "amd-gfx@...ts.freedesktop.org"
<amd-gfx@...ts.freedesktop.org>, "linux-arm-msm@...r.kernel.org"
<linux-arm-msm@...r.kernel.org>, "freedreno@...ts.freedesktop.org"
<freedreno@...ts.freedesktop.org>, "intel-xe@...ts.freedesktop.org"
<intel-xe@...ts.freedesktop.org>, "linux-mmc@...r.kernel.org"
<linux-mmc@...r.kernel.org>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
<intel-wired-lan@...ts.osuosl.org>, "linux-pci@...r.kernel.org"
<linux-pci@...r.kernel.org>, "linux-s390@...r.kernel.org"
<linux-s390@...r.kernel.org>, "linux-scsi@...r.kernel.org"
<linux-scsi@...r.kernel.org>, "linux-staging@...ts.linux.dev"
<linux-staging@...ts.linux.dev>, "ceph-devel@...r.kernel.org"
<ceph-devel@...r.kernel.org>, "linux-trace-kernel@...r.kernel.org"
<linux-trace-kernel@...r.kernel.org>
CC: Rasmus Villemoes <linux@...musvillemoes.dk>, Sergey Senozhatsky
<senozhatsky@...omium.org>, Jonathan Corbet <corbet@....net>, Sumit Semwal
<sumit.semwal@...aro.org>, Gustavo Padovan <gustavo@...ovan.org>, David
Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
<mripard@...nel.org>, Dmitry Baryshkov <lumag@...nel.org>, Abhinav Kumar
<abhinav.kumar@...ux.dev>, Jessica Zhang <jesszhan0024@...il.com>, Sean Paul
<sean@...rly.run>, Marijn Suijten <marijn.suijten@...ainline.org>, Konrad
Dybcio <konradybcio@...nel.org>, Lucas De Marchi <lucas.demarchi@...el.com>,
Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>, Vladimir Oltean <olteanv@...il.com>,
Andrew Lunn <andrew@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek
Kitszel <przemyslaw.kitszel@...el.com>,
Krzysztof Wilczyński <kwilczynski@...nel.org>, Kishon
Vijay Abraham I <kishon@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
Rodolfo Giometti <giometti@...eenne.com>, Jonathan Lemon
<jonathan.lemon@...il.com>, Richard Cochran <richardcochran@...il.com>,
Stefan Haberland <sth@...ux.ibm.com>, Jan Hoeppner <hoeppner@...ux.ibm.com>,
Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger
<borntraeger@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>, "Satish
Kharat (satishkh)" <satishkh@...co.com>, "Sesidhar Baddela (sebaddel)"
<sebaddel@...co.com>, "James E.J. Bottomley"
<James.Bottomley@...senPartnership.com>, Mauro Carvalho Chehab
<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Xiubo
Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, Masami Hiramatsu
<mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: RE: [PATCH v3 19/21] scsi: fnic: Switch to use %ptSp
On Thursday, November 13, 2025 6:33 AM, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
>
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> drivers/scsi/fnic/fnic_trace.c | 52 ++++++++++++++--------------------
> 1 file changed, 22 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> index cdc6b12b1ec2..0a849a195a8e 100644
> --- a/drivers/scsi/fnic/fnic_trace.c
> +++ b/drivers/scsi/fnic/fnic_trace.c
> @@ -138,9 +138,8 @@ int fnic_get_trace_data(fnic_dbgfs_t *fnic_dbgfs_prt)
> */
> len += scnprintf(fnic_dbgfs_prt->buffer + len,
> (trace_max_pages * PAGE_SIZE * 3) - len,
> - "%16llu.%09lu %-50s %8x %8x %16llx %16llx "
> - "%16llx %16llx %16llx\n", (u64)val.tv_sec,
> - val.tv_nsec, str, tbp->host_no, tbp->tag,
> + "%ptSp %-50s %8x %8x %16llx %16llx %16llx %16llx %16llx\n",
> + &val, str, tbp->host_no, tbp->tag,
> tbp->data[0], tbp->data[1], tbp->data[2],
> tbp->data[3], tbp->data[4]);
> rd_idx++;
> @@ -180,9 +179,8 @@ int fnic_get_trace_data(fnic_dbgfs_t *fnic_dbgfs_prt)
> */
> len += scnprintf(fnic_dbgfs_prt->buffer + len,
> (trace_max_pages * PAGE_SIZE * 3) - len,
> - "%16llu.%09lu %-50s %8x %8x %16llx %16llx "
> - "%16llx %16llx %16llx\n", (u64)val.tv_sec,
> - val.tv_nsec, str, tbp->host_no, tbp->tag,
> + "%ptSp %-50s %8x %8x %16llx %16llx %16llx %16llx %16llx\n",
> + &val, str, tbp->host_no, tbp->tag,
> tbp->data[0], tbp->data[1], tbp->data[2],
> tbp->data[3], tbp->data[4]);
> rd_idx++;
> @@ -215,30 +213,26 @@ int fnic_get_stats_data(struct stats_debug_info *debug,
> {
> int len = 0;
> int buf_size = debug->buf_size;
> - struct timespec64 val1, val2;
> + struct timespec64 val, val1, val2;
> int i = 0;
>
> - ktime_get_real_ts64(&val1);
> + ktime_get_real_ts64(&val);
> len = scnprintf(debug->debug_buffer + len, buf_size - len,
> "------------------------------------------\n"
> "\t\tTime\n"
> "------------------------------------------\n");
>
> + val1 = timespec64_sub(val, stats->stats_timestamps.last_reset_time);
> + val2 = timespec64_sub(val, stats->stats_timestamps.last_read_time);
> len += scnprintf(debug->debug_buffer + len, buf_size - len,
> - "Current time : [%lld:%ld]\n"
> - "Last stats reset time: [%lld:%09ld]\n"
> - "Last stats read time: [%lld:%ld]\n"
> - "delta since last reset: [%lld:%ld]\n"
> - "delta since last read: [%lld:%ld]\n",
> - (s64)val1.tv_sec, val1.tv_nsec,
> - (s64)stats->stats_timestamps.last_reset_time.tv_sec,
> - stats->stats_timestamps.last_reset_time.tv_nsec,
> - (s64)stats->stats_timestamps.last_read_time.tv_sec,
> - stats->stats_timestamps.last_read_time.tv_nsec,
> - (s64)timespec64_sub(val1, stats->stats_timestamps.last_reset_time).tv_sec,
> - timespec64_sub(val1, stats->stats_timestamps.last_reset_time).tv_nsec,
> - (s64)timespec64_sub(val1, stats->stats_timestamps.last_read_time).tv_sec,
> - timespec64_sub(val1, stats->stats_timestamps.last_read_time).tv_nsec);
> + "Current time : [%ptSp]\n"
> + "Last stats reset time: [%ptSp]\n"
> + "Last stats read time: [%ptSp]\n"
> + "delta since last reset: [%ptSp]\n"
> + "delta since last read: [%ptSp]\n",
> + &val,
> + &stats->stats_timestamps.last_reset_time, &val1,
> + &stats->stats_timestamps.last_read_time, &val2);
>
> stats->stats_timestamps.last_read_time = val1;
>
> @@ -416,8 +410,8 @@ int fnic_get_stats_data(struct stats_debug_info *debug,
> jiffies_to_timespec64(stats->misc_stats.last_ack_time, &val2);
>
> len += scnprintf(debug->debug_buffer + len, buf_size - len,
> - "Last ISR time: %llu (%8llu.%09lu)\n"
> - "Last ACK time: %llu (%8llu.%09lu)\n"
> + "Last ISR time: %llu (%ptSp)\n"
> + "Last ACK time: %llu (%ptSp)\n"
> "Max ISR jiffies: %llu\n"
> "Max ISR time (ms) (0 denotes < 1 ms): %llu\n"
> "Corr. work done: %llu\n"
> @@ -437,10 +431,8 @@ int fnic_get_stats_data(struct stats_debug_info *debug,
> "Number of rport not ready: %lld\n"
> "Number of receive frame errors: %lld\n"
> "Port speed (in Mbps): %lld\n",
> - (u64)stats->misc_stats.last_isr_time,
> - (s64)val1.tv_sec, val1.tv_nsec,
> - (u64)stats->misc_stats.last_ack_time,
> - (s64)val2.tv_sec, val2.tv_nsec,
> + (u64)stats->misc_stats.last_isr_time, &val1,
> + (u64)stats->misc_stats.last_ack_time, &val2,
> (u64)atomic64_read(&stats->misc_stats.max_isr_jiffies),
> (u64)atomic64_read(&stats->misc_stats.max_isr_time_ms),
> (u64)atomic64_read(&stats->misc_stats.corr_work_done),
> @@ -857,8 +849,8 @@ void copy_and_format_trace_data(struct fc_trace_hdr *tdata,
> len = *orig_len;
>
> len += scnprintf(fnic_dbgfs_prt->buffer + len, max_size - len,
> - "%ptTs.%09lu ns%8x %c%8x\t",
> - &tdata->time_stamp.tv_sec, tdata->time_stamp.tv_nsec,
> + "%ptSs ns%8x %c%8x\t",
> + &tdata->time_stamp,
> tdata->host_no, tdata->frame_type, tdata->frame_len);
>
> fc_trace = (char *)FC_TRACE_ADDRESS(tdata);
> --
> 2.50.1
>
>
Acked-by: Karan Tilak Kumar <kartilak@...co.com>
Thanks for the change, Andy.
Can you please advise how I can compile test this change?
Regards,
Karan
Powered by blists - more mailing lists