linux-kernel - RE: [PATCH 1/3] drm: zynqmp: Check property creation status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MW4PR12MB71657E3EF2B400C4A583E500E6CDA@MW4PR12MB7165.namprd12.prod.outlook.com>
Date: Thu, 13 Nov 2025 23:05:34 +0000
From: "Klymenko, Anatoliy" <Anatoliy.Klymenko@....com>
To: Sean Anderson <sean.anderson@...ux.dev>, Laurent Pinchart
	<laurent.pinchart@...asonboard.com>, Tomi Valkeinen
	<tomi.valkeinen@...asonboard.com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mike
 Looijmans <mike.looijmans@...ic.nl>, David Airlie <airlied@...il.com>, Thomas
 Zimmermann <tzimmermann@...e.de>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, Simona Vetter <simona@...ll.ch>,
	"Simek, Michal" <michal.simek@....com>
Subject: RE: [PATCH 1/3] drm: zynqmp: Check property creation status

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Sean,

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...ux.dev>
> Sent: Thursday, November 13, 2025 12:37 PM
> To: Laurent Pinchart <laurent.pinchart@...asonboard.com>; Tomi Valkeinen
> <tomi.valkeinen@...asonboard.com>; dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org; Mike Looijmans <mike.looijmans@...ic.nl>;
> David Airlie <airlied@...il.com>; Thomas Zimmermann
> <tzimmermann@...e.de>; Maarten Lankhorst
> <maarten.lankhorst@...ux.intel.com>; Klymenko, Anatoliy
> <Anatoliy.Klymenko@....com>; Maxime Ripard <mripard@...nel.org>; linux-
> arm-kernel@...ts.infradead.org; Simona Vetter <simona@...ll.ch>; Simek,
> Michal <michal.simek@....com>; Sean Anderson
> <sean.anderson@...ux.dev>
> Subject: [PATCH 1/3] drm: zynqmp: Check property creation status
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Make sure to return an error in the event that we can't create our
> properties.
>
> Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support")
> Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to
> userspace")
>
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> ---
>
>  drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index 2bee0a2275ed..c80a2d4034f3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -174,9 +174,15 @@ static int zynqmp_dpsub_create_planes(struct
> zynqmp_dpsub *dpsub)
>
>                 drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs);
>
> -               drm_plane_create_zpos_immutable_property(plane, i);
> -               if (i == ZYNQMP_DPSUB_LAYER_GFX)
> -                       drm_plane_create_alpha_property(plane);
> +               ret = drm_plane_create_zpos_immutable_property(plane, i);
> +               if (ret)
> +                       return ret;
> +
> +               if (i == ZYNQMP_DPSUB_LAYER_GFX) {
> +                       ret = drm_plane_create_alpha_property(plane);
> +                       if (ret)
> +                               return ret;
> +               }
>         }
>
>         return 0;
> --
> 2.35.1.1320.gc452695387.dirty

Looks good to me.

Reviewed-by: Anatoliy Klymenko <anatoliy.klymenko@....com>

Thank you,
Anatoliy