linux-kernel - Re: [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af66cc8a-051a-4512-9a02-468b17550775@mleia.com>
Date: Fri, 14 Nov 2025 01:55:50 +0200
From: Vladimir Zapolskiy <vz@...ia.com>
To: Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/LPC32XX SOC SUPPORT"
 <linux-arm-kernel@...ts.infradead.org>,
 open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/5] ARM: dts: lpc32xx: add bus surfix for simple-bus

Hi Frank.

On 10/29/25 22:27, Frank Li wrote:
> add bus surfix for simple-bus to fix below CHECK_DTBS warnings:

typo in the subject and in the commit message above, s/surfix/suffix/

> arm/boot/dts/nxp/lpc/lpc3250-ea3250.dtb: usb (simple-bus): $nodename:0: 'usb' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
>          from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>   arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 2236901a00313..9790b0a1d6537 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -86,7 +86,7 @@ dma: dma-controller@...00000 {
>   			#dma-cells = <2>;
>   		};
>   
> -		usb {
> +		usb-bus {

Device nodes under "usb" should be just elevated, the "simple-bus" here
was used only to group some controllers together.

>   			#address-cells = <1>;
>   			#size-cells = <1>;
>   			compatible = "simple-bus";
> @@ -307,14 +307,14 @@ mpwm: pwm@...e8000 {
>   			};
>   		};
>   
> -		fab {
> +		fab-bus {

FAB shall find its place in the AXI/AHB/APB/... list, isn't it?

>   			#address-cells = <1>;
>   			#size-cells = <1>;
>   			compatible = "simple-bus";
>   			ranges = <0x20000000 0x20000000 0x30000000>;
>   
>   			/* System Control Block */
> -			scb {
> +			scb-bus {
>   				compatible = "simple-bus";
>   				ranges = <0x0 0x40004000 0x00001000>;
>   				#address-cells = <1>;

Here "simple-bus" is also unjustified...

-- 
Best wishes,
Vladimir