linux-kernel - Re: [PATCH v2 2/3] dm-pcache: reuse meta_addr in pcache_meta_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c7c6147-f49d-425d-820f-dfe4f04623cb@linux.dev>
Date: Thu, 13 Nov 2025 14:40:02 +0800
From: Dongsheng Yang <dongsheng.yang@...ux.dev>
To: Li Chen <me@...ux.beauty>, dm-devel@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Zheng Gu <cengku@...il.com>
Subject: Re: [PATCH v2 2/3] dm-pcache: reuse meta_addr in
 pcache_meta_find_latest


在 11/11/2025 8:13 PM, Li Chen 写道:
> From: Li Chen <chenl311@...natelecom.cn>
>
> pcache_meta_find_latest() already computes the metadata address as
> meta_addr. Reuse that instead of recomputing.
>
> Signed-off-by: Li Chen <chenl311@...natelecom.cn>


Reviewed-by： Dongsheng Yang <dongsheng.yang@...ux.dev


> ---
>   drivers/md/dm-pcache/pcache_internal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-pcache/pcache_internal.h b/drivers/md/dm-pcache/pcache_internal.h
> index d427e534727c..b7a3319d2bd3 100644
> --- a/drivers/md/dm-pcache/pcache_internal.h
> +++ b/drivers/md/dm-pcache/pcache_internal.h
> @@ -99,7 +99,7 @@ static inline void __must_check *pcache_meta_find_latest(struct pcache_meta_head
>   		/* Update latest if a more recent sequence is found */
>   		if (!latest || pcache_meta_seq_after(meta->seq, seq_latest)) {
>   			seq_latest = meta->seq;
> -			latest = (void *)header + (i * meta_max_size);
> +			latest = meta_addr;
>   		}
>   	}
>