linux-kernel - Re: [PATCH v2 2/2] arm: dts: ti: Adds support for AM335x and AM437x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1253388251.49228.1763017746545.JavaMail.zimbra@couthit.local>
Date: Thu, 13 Nov 2025 12:39:06 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: afd <afd@...com>
Cc: nm <nm@...com>, Vignesh Raghavendra <vigneshr@...com>, 
	tony <tony@...mide.com>, robh <robh@...nel.org>, 
	krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>, 
	richardcochran <richardcochran@...il.com>, 
	linux-omap <linux-omap@...r.kernel.org>, 
	devicetree <devicetree@...r.kernel.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>, 
	netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>, 
	danishanwar <danishanwar@...com>, pratheesh <pratheesh@...com>, 
	j-rameshbabu <j-rameshbabu@...com>, praneeth <praneeth@...com>, 
	srk <srk@...com>, rogerq <rogerq@...com>, 
	krishna <krishna@...thit.com>, mohan <mohan@...thit.com>, 
	pmohan <pmohan@...thit.com>, basharath <basharath@...thit.com>, 
	m-karicheri2 <m-karicheri2@...com>, parvathi <parvathi@...thit.com>
Subject: Re: [PATCH v2 2/2] arm: dts: ti: Adds support for AM335x and AM437x

Hi,

> Hi,
> 
>> On 11/3/25 6:47 AM, Parvathi Pudi wrote:
>>> From: Roger Quadros <rogerq@...com>
>>> 
>>> PRU-ICSS instance consists of two PRU cores along with various
>>> peripherals such as the Interrupt Controller (PRU_INTC), the Industrial
>>> Ethernet Peripheral(IEP), the Real Time Media Independent Interface
>>> controller (MII_RT), and the Enhanced Capture (eCAP) event module.
>>> 
>>> The TI Sitara AM335x ICE-V2 consists of single PRU-ICSS instance,
>>> This patch adds the new device tree source file in-order to use
>>> PRU-ICSS instance, along with makefile changes to add the new DTS
>>> file for PRUSS.
>>> 
>>> The TI Sitara AM437x series of devices consists of 2 PRU-ICSS instances
>>> (PRU-ICSS0 and PRU-ICSS1). This patch adds the device tree nodes for the
>>> PRU-ICSS1 instance to support DUAL-MAC mode of operation. Support for
>>> Ethernet over PRU is available only for ICSS1 instance.
>>> 
>>> am33xx-l4.dtsi, am4372.dtsi - Adds IEP and eCAP peripheral as child nodes
>>> of the PRUSS subsystem node.
>>> 
>>> am335x-icev2-prueth.dts, am437x-idk-evm.dts - Adds PRU-ICSS
>>> instance node along with PRU eth port information and corresponding
>>> port configuration. It includes interrupt mapping for packet reception,
>>> HW timestamp collection, and PRU Ethernet ports in MII mode,
>>> 
>>> GPIO configuration, boot strapping along with delay configuration for
>>> individual PRU Ethernet port and other required nodes.
>>> 
>>> Signed-off-by: Roger Quadros <rogerq@...com>
>>> Signed-off-by: Andrew F. Davis <afd@...com>
>>> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
>>> Signed-off-by: Basharath Hussain Khaja <basharath@...thit.com>
>>> Signed-off-by: Parvathi Pudi <parvathi@...thit.com>
>>> ---
>>>   arch/arm/boot/dts/ti/omap/Makefile            |   1 +
>>>   .../boot/dts/ti/omap/am335x-icev2-prueth.dts  | 533 ++++++++++++++++++
>>>   arch/arm/boot/dts/ti/omap/am33xx-l4.dtsi      |  11 +
>>>   arch/arm/boot/dts/ti/omap/am4372.dtsi         |  11 +
>>>   arch/arm/boot/dts/ti/omap/am437x-idk-evm.dts  | 137 ++++-
>>>   5 files changed, 692 insertions(+), 1 deletion(-)
>>>   create mode 100644 arch/arm/boot/dts/ti/omap/am335x-icev2-prueth.dts
>>> 
>>> diff --git a/arch/arm/boot/dts/ti/omap/Makefile
>>> b/arch/arm/boot/dts/ti/omap/Makefile
>>> index 1aef60eef671..d06dd31d0bb6 100644
>>> --- a/arch/arm/boot/dts/ti/omap/Makefile
>>> +++ b/arch/arm/boot/dts/ti/omap/Makefile
>>> @@ -100,6 +100,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
>>>   	am335x-evmsk.dtb \
>>>   	am335x-guardian.dtb \
>>>   	am335x-icev2.dtb \
>>> +	am335x-icev2-prueth.dtb \
>> 
>> This new DTB looks to be almost identical to the regular am335x-icev2.dtb, to
>> add an optional node to an existing board use DT overlay, do not clone the
>> whole board DT just to add a node. Maybe that is how we hacked around this
>> in our evil vendor tree back in 2018 but do not take our old hacks and push
>> them upstream as-is.
>> 
>> Andrew
>> 
> 
> Understood. We will review this redundancy and revert back with an update.
> 

We have created a device tree overlay file (am335x-icev2-prueth-overlay.dtso)
that will disable CPSW nodes defined in "am335x-icev2.dts" and enables the PRUETH
nodes at boot time depending on pin configuration. We will update the Makefile to
merge it with the base DTS to generate a device tree binary.

We will post the revised version v3 shortly.

Thanks and Regards,
Parvathi.