linux-kernel - Re: [PATCH 1/2] zram: introduce bio batching support for faster writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <txgn6y47vwxb2d537374lklpbwwxy4r46okqgbvqxwxppjfwhj@wttkbv2pjjpx>
Date: Thu, 13 Nov 2025 16:16:28 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, 
	Minchan Kim <minchan@...nel.org>, Yuwen Chen <ywen.chen@...mail.com>, 
	Richard Chang <richardycc@...gle.com>, Brian Geffon <bgeffon@...gle.com>, 
	Fengyu Lian <licayy@...look.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	linux-block@...r.kernel.org
Subject: Re: [PATCH 1/2] zram: introduce bio batching support for faster
 writeback

On (25/11/13 14:59), Sergey Senozhatsky wrote:
[..]
> @@ -775,67 +980,41 @@ static int zram_writeback_slots(struct zram *zram, struct zram_pp_ctl *ctl)
>  		 */
>  		if (!zram_test_flag(zram, index, ZRAM_PP_SLOT))
>  			goto next;
> -		if (zram_read_from_zspool(zram, page, index))
> +		if (zram_read_from_zspool(zram, req->page, index))
>  			goto next;
>  		zram_slot_unlock(zram, index);
>  
> -		bio_init(&bio, zram->bdev, &bio_vec, 1,
> +		req->blk_idx = blk_idx;
> +		req->pps = pps;

This should move ownership of pps from pps_ctl to req.  Will fix in the next
iteration (apparently compile-testing is not the same as testing).