linux-kernel - Re: [PATCH V3 18/20] cxl/pmem_region: Prep patch to accommodate pmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1931444790.41763020203119.JavaMail.epsvc@epcpadp1new>
Date: Thu, 13 Nov 2025 12:59:07 +0530
From: Neeraj Kumar <s.neeraj@...sung.com>
To: Dave Jiang <dave.jiang@...el.com>
Cc: linux-cxl@...r.kernel.org, nvdimm@...ts.linux.dev,
	linux-kernel@...r.kernel.org, gost.dev@...sung.com,
	a.manzanares@...sung.com, vishak.g@...sung.com, neeraj.kernel@...il.com,
	cpgs@...sung.com
Subject: Re: [PATCH V3 18/20] cxl/pmem_region: Prep patch to accommodate
 pmem_region attributes

On 12/11/25 08:40AM, Dave Jiang wrote:
>

<snip>

>> Keeping these functions in core/region.c (CONFIG_REGION)) and manually enabling CONFIG_LIBNVDIMM=y
>> will make it pass.
>>
>> Even if we can put these functions in core/region.c and forcefully make
>> libnvdimm (CONFIG_LIBNVDIMM) dependent using Kconfig. But I find it little improper as
>> this new dependency is not for all type of cxl devices (vmem and pmem) but only for cxl pmem
>> device region.
>>
>> Therefore I have seperated it out in core/pmem_region.c under Kconfig control
>> making libnvdimm forcefully enable if CONFIG_CXL_PMEM_REGION == y
>>
>> So, I believe this prep patch is required for this LSA 2.1 support.
>
>I think you misunderstood what I said. What I was trying to say is if possible to move all the diff changes of moving the existing code to a different place to a different patch. That way this patch is not full of those diff changes and make it easier to review.
>
>DJ

Hi Dave, Thanks for the clarification. Yes now I am able to get your point clear.

I should split this patch into two patches
1. First prep patch with no functionality change (Just code movement from core/region.c to newly core/pmem_region.c)
2. Second patch which calls the libnvdimm exported routines
	- region_label_update_show/store()
	- region_label_delete_store()

Regards,
Neeraj