linux-kernel - Re: [PATCH v2 20/21] dt-bindings: display/msm/gmu: Add Adreno X2-85 GMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58176e8c-a4f0-496e-aad8-83698986ec4b@kernel.org>
Date: Thu, 13 Nov 2025 09:21:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Akhil P Oommen <akhilpo@....qualcomm.com>
Cc: Rob Clark <robin.clark@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Sean Paul <sean@...rly.run>,
 Dmitry Baryshkov <lumag@...nel.org>, Abhinav Kumar
 <abhinav.kumar@...ux.dev>, Jessica Zhang <jesszhan0024@...il.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Jonathan Marek <jonathan@...ek.ca>, Jordan Crouse
 <jordan@...micpenguin.net>, Will Deacon <will@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Joerg Roedel <joro@...tes.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Connor Abbott <cwabbott0@...il.com>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 iommu@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 20/21] dt-bindings: display/msm/gmu: Add Adreno X2-85
 GMU

On 13/11/2025 09:14, Krzysztof Kozlowski wrote:
> On 11/11/2025 15:25, Akhil P Oommen wrote:
>> On 11/11/2025 1:19 PM, Krzysztof Kozlowski wrote:
>>> On Mon, Nov 10, 2025 at 10:07:26PM +0530, Akhil P Oommen wrote:
>>>> Document Adreno X2-85 GMU found in Glymur chipsets in the
>>>> dt-binding specification. It is very similar to Adreno 840
>>>> GMU with the additional requirement of RSCC HUB clock.
>>>>
>>>> Signed-off-by: Akhil P Oommen <akhilpo@....qualcomm.com>
>>>> ---
>>>
>>> <form letter>
>>> This is a friendly reminder during the review process.
>>>
>>> It looks like you received a tag and forgot to add it.
>>>
>>> If you do not know the process, here is a short explanation:
>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>>> versions of patchset, under or above your Signed-off-by tag, unless
>>> patch changed significantly (e.g. new properties added to the DT
>>> bindings). Tag is "received", when provided in a message replied to you
>>> on the mailing list. Tools like b4 can help here. However, there's no
>>> need to repost patches *only* to add the tags. The upstream maintainer
>>> will do that for tags received on the version they apply.
>>>
>>> Please read:
>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>>
>>> If a tag was not added on purpose, please state why and what changed.
>>> </form letter>
>>>
>>
>> I think you got confused. These are new patches I have included for
>> Glymur support in Rev 2 (as mentioned in the cover letter). Did you
>> confuse with the other patch for Kaanapali?
> 
> I did check in the changelog and there is nothing about new bindings
> patch, so you expect me to keep guessing what is happening here.
> 
> Squash this with previous patch then. It's really churn to deal with one
> single liner per patch and commit msg has absoutely ZERO content to be
> useful on its own.

I meant, squash the second patch with one liner. This one is fine.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof