linux-kernel - Re: [PATCH] samples: rust: fix endianness issue in rust_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=fr8tTYXz7Wd5AYr-1f+6ohggTfGBz5KWDE97675MP+A@mail.gmail.com>
Date: Thu, 13 Nov 2025 09:27:14 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Marko Turk <mt@...koturk.info>, Dirk Behme <dirk.behme@...bosch.com>, bhelgaas@...gle.com, 
	kwilczynski@...nel.org, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] samples: rust: fix endianness issue in rust_driver_pci

On Thu, Nov 13, 2025 at 9:22 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> I don't think we should do anything else; the cases where we need to deal with
> big-endian devices for MMIO should be extremely rare -- rare enough that there
> aren't even corresponding *_be() implementations for all architectures.
>
> Given that, I think the proper fix is to drop the existing u32::from_le() call
> (that ended up in the sample driver by accident) and properly document the
> little-endian assumption of the MMIO backend.

Sounds good then, thanks!

Cheers,
Miguel