linux-kernel - Re: [PATCH v2 09/11] powercap: dtpm: Simplify with of_machine_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <953f1aaa-d8bd-4091-9bf6-9538ccdd3bfa@arm.com>
Date: Thu, 13 Nov 2025 09:50:40 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Samuel Holland <samuel@...lland.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Viresh Kumar <viresh.kumar@...aro.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Thierry Reding <thierry.reding@...il.com>,
 Daniel Lezcano <daniel.lezcano@...nel.org>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Saravana Kannan <saravanak@...gle.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Thomas Gleixner <tglx@...utronix.de>,
 Maximilian Luz <luzmaximilian@...il.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>, linux-pm@...r.kernel.org,
 Chen-Yu Tsai <wens@...nel.org>, Yangtao Li <tiny.windzz@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, linux-tegra@...r.kernel.org,
 Rob Herring <robh@...nel.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Hans de Goede <hansg@...nel.org>
Subject: Re: [PATCH v2 09/11] powercap: dtpm: Simplify with
 of_machine_get_match_data()

On 11/12/25 10:28, Krzysztof Kozlowski wrote:
> Replace open-coded getting root OF node, matching against it and getting
> the match data with new of_machine_get_match_data() helper.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Depends on the first OF patch.
> ---
>   drivers/powercap/dtpm.c | 16 +---------------
>   1 file changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
> index f390665743c4..129d55bc705c 100644
> --- a/drivers/powercap/dtpm.c
> +++ b/drivers/powercap/dtpm.c
> @@ -548,9 +548,7 @@ static int dtpm_for_each_child(const struct dtpm_node *hierarchy,
>    */
>   int dtpm_create_hierarchy(struct of_device_id *dtpm_match_table)
>   {
> -	const struct of_device_id *match;
>   	const struct dtpm_node *hierarchy;
> -	struct device_node *np;
>   	int i, ret;
>   
>   	mutex_lock(&dtpm_lock);
> @@ -567,19 +565,7 @@ int dtpm_create_hierarchy(struct of_device_id *dtpm_match_table)
>   		goto out_pct;
>   	}
>   
> -	ret = -ENODEV;
> -	np = of_find_node_by_path("/");
> -	if (!np)
> -		goto out_err;
> -
> -	match = of_match_node(dtpm_match_table, np);
> -
> -	of_node_put(np);
> -
> -	if (!match)
> -		goto out_err;
> -
> -	hierarchy = match->data;
> +	hierarchy = of_machine_get_match_data(dtpm_match_table);
>   	if (!hierarchy) {
>   		ret = -EFAULT;
>   		goto out_err;
> 

I don't know if Daniel had a chance to look at it, but I can help him.

The patch looks OK.

The extra return error value which is removed doesn't harm the client of
this function in other subsystem.

Reviewed-by: Lukasz Luba <lukasz.luba@....com>