linux-kernel - Re: [PATCH] UFS: Make TM command timeout configurable from host side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b83804a8419f0e8cc1a6263144fbaf1583bab2ed.camel@mediatek.com>
Date: Thu, 13 Nov 2025 10:08:36 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "beanhuo@...ron.com" <beanhuo@...ron.com>, "sh043.lee@...sung.com"
	<sh043.lee@...sung.com>, "avri.altman@....com" <avri.altman@....com>,
	"storage.sec@...sung.com" <storage.sec@...sung.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"bvanassche@....org" <bvanassche@....org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "adrian.hunter@...el.com"
	<adrian.hunter@...el.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH] UFS: Make TM command timeout configurable from host side

On Wed, 2025-11-12 at 08:51 -0800, Bart Van Assche wrote:
> 
> Can't we increase the default timeout (TM_CMD_TIMEOUT)? Increasing
> the
> default timeout shouldn't affect any configuration negatively, isn't
> it?
> 

Hi Bart,

In the worst-case scenario (when the device is stuck), it 
may takes 1.1 seconds to abort a single task. When the queue is 
full (64), there will be noticeable lag. Aborting all 
tasks can take over a minute, which is unacceptable regardless 
of whether TM_CMD_TIMEOUT is increased or not. Under normal 
conditions, it’s very unlikely to exceed 100ms. So I think 
directly modifying TM_CMD_TIMEOUT is also acceptable, 
but I suggest keeping it within 500ms.

However, the optimal solution is for the vendor to update
the firmware, ensuring that TM command priority is set 
appropriately to prevent situations where it exceeds 100ms.

Thanks
Peter