linux-kernel - Re: [PATCH] PCI: cadence: Kconfig: change PCIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da56386a-b6ac-4034-a063-811cd7d71fa5@cixtech.com>
Date: Thu, 13 Nov 2025 18:38:21 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: Siddharth Vadapalli <s-vadapalli@...com>, lpieralisi@...nel.org,
 kwilczynski@...nel.org, mani@...nel.org, robh@...nel.org,
 bhelgaas@...gle.com, unicorn_wang@...look.com, kishon@...nel.org
Cc: arnd@...db.de, stable@...r.kernel.org, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 srk@...com
Subject: Re: [PATCH] PCI: cadence: Kconfig: change PCIE_CADENCE configs from
 tristate to bool

Hi Siddharth,


Your patch repeats this part.


https://patchwork.kernel.org/project/linux-pci/patch/20251108140305.1120117-2-hans.zhang@cixtech.com/

Best regards,
Hans

On 11/13/2025 5:27 PM, Siddharth Vadapalli wrote:
> EXTERNAL EMAIL
> 
> The drivers associated with the PCIE_CADENCE, PCIE_CADENCE_HOST AND
> PCIE_CADENCE_EP configs are used by multiple vendor drivers and serve as a
> library of helpers. Since the vendor drivers could individually be built
> as built-in or as loadable modules, it is possible to select a build
> configuration wherein a vendor driver is built-in while the library is
> built as a loadable module. This will result in a build error as reported
> in the 'Closes' link below.
> 
> Address the build error by changing the library configs to be 'bool'
> instead of 'tristate'.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511111705.MZ7ls8Hm-lkp@intel.com/
> Fixes: 1c72774df028 ("PCI: sg2042: Add Sophgo SG2042 PCIe driver")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> ---
>   drivers/pci/controller/cadence/Kconfig | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig
> index 02a639e55fd8..980da64ce730 100644
> --- a/drivers/pci/controller/cadence/Kconfig
> +++ b/drivers/pci/controller/cadence/Kconfig
> @@ -4,16 +4,16 @@ menu "Cadence-based PCIe controllers"
>          depends on PCI
> 
>   config PCIE_CADENCE
> -       tristate
> +       bool
> 
>   config PCIE_CADENCE_HOST
> -       tristate
> +       bool
>          depends on OF
>          select IRQ_DOMAIN
>          select PCIE_CADENCE
> 
>   config PCIE_CADENCE_EP
> -       tristate
> +       bool
>          depends on OF
>          depends on PCI_ENDPOINT
>          select PCIE_CADENCE
> --
> 2.51.1
> 
>