linux-kernel - Re: [PATCH] drm/komeda: Convert logging in komeda_event.c to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRW1fobS0XbAJPTF@e110455-lin.cambridge.arm.com>
Date: Thu, 13 Nov 2025 10:39:58 +0000
From: Liviu Dudau <liviu.dudau@....com>
To: Abhishek Rajput <abhiraj21put@...il.com>
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/komeda: Convert logging in komeda_event.c to drm_*
 with

On Thu, Nov 13, 2025 at 03:36:23PM +0530, Abhishek Rajput wrote:
> Replace the DRM_ERROR() call in
> drivers/gpu/drm/arm/display/komeda/komeda_event.c with the corresponding
> drm_err() helper that uses the existing drm_device parameter.
> 
> Using drm_err() allows the DRM core to prefix log messages with the
> specific DRM device name and instance, which helps distinguish logs when
> multiple display controllers are present.
> 
> This change aligns komeda_event.c with the DRM TODO item:
> "Convert logging to drm_* functions with drm_device parameter".
> 
> Signed-off-by: Abhishek Rajput <abhiraj21put@...il.com>

Reviewed-by: Liviu Dudau <liviu.dudau@....com>

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index 53f944e66dfc..78a4a78d1fab 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -148,7 +148,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev)
>  		komeda_sprintf(&str, ", pipes[1]: ");
>  		evt_str(&str, evts->pipes[1]);
>  
> -		DRM_ERROR("err detect: %s\n", msg);
> +		drm_err(dev, "err detect: %s\n", msg);
>  		if ((err_verbosity & KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT) &&
>  		    (evts_mask & (KOMEDA_ERR_EVENTS | KOMEDA_WARN_EVENTS)))
>  			drm_state_dump(dev, &p);
> -- 
> 2.43.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯