linux-kernel - Re: [PATCH v1] nvmem: core: update cell->bytes after shifting bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJM55Z8te25nDEW9hGT9rRzSwwKzkEBJPLfCpwgMwxvUzu+5Yw@mail.gmail.com>
Date: Thu, 13 Nov 2025 03:36:55 -0800
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Srinivas Kandagatla <srini@...nel.org>, linux-kernel@...r.kernel.org
Cc: Samuel Holland <samuel@...lland.org>, Dmitry Baryshkov <lumag@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1] nvmem: core: update cell->bytes after shifting bits

Quoting Srinivas Kandagatla (2025-11-10 09:32:08)
>
>
> On 9/30/25 3:22 PM, Emil Renner Berthing wrote:
> > When support for bit offsets of more than one byte was added it
> > unfortunately left the cell->bytes value at the number of bytes read
> > including the offset. Make sure to update it to the proper number of
> > meaningful bytes in the returned data.
> Sorry somehow I missed this patch.
>
> If the number of bytes are different to the bytes that are part of cell
> then the parsing code seems to have missed some cases, which is the
> right place to fix.
>
> Can you share more details on the values that you pass as part of the
> cell definition.

Yes, the node effectively looks like this:

sid: efuse@...6000 {
        compatible = "allwinner,sun20i-d1-sid";
        reg = <0x3006000 0x1000>;
        #address-cells = <1>;
        #size-cells = <1>;

        ths_calib: ths-calib@14 {
                reg = <0x14 0x4>;
        };

        bg_trim: bg-trim@28 {
                reg = <0x28 0x4>;
                bits = <16 8>;
        };
};

/Emil