linux-kernel - Re: [PATCH v1 2/4] cpuidle: governors: teo: Drop redundant function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b70a9578-74ed-4ac4-bd8c-90b075439112@arm.com>
Date: Thu, 13 Nov 2025 11:46:53 +0000
From: Christian Loehle <christian.loehle@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
 Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Reka Norman <rekanorman@...omium.org>
Subject: Re: [PATCH v1 2/4] cpuidle: governors: teo: Drop redundant function
 parameter

On 11/12/25 16:23, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The last no_poll parameter of teo_find_shallower_state() is always
> false, so drop it.
> 
> No intentional functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Reviewed-by: Christian Loehle <christian.loehle@....com>

> ---
>  drivers/cpuidle/governors/teo.c |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> --- a/drivers/cpuidle/governors/teo.c
> +++ b/drivers/cpuidle/governors/teo.c
> @@ -239,17 +239,15 @@ static bool teo_state_ok(int i, struct c
>   * @dev: Target CPU.
>   * @state_idx: Index of the capping idle state.
>   * @duration_ns: Idle duration value to match.
> - * @no_poll: Don't consider polling states.
>   */
>  static int teo_find_shallower_state(struct cpuidle_driver *drv,
>  				    struct cpuidle_device *dev, int state_idx,
> -				    s64 duration_ns, bool no_poll)
> +				    s64 duration_ns)
>  {
>  	int i;
>  
>  	for (i = state_idx - 1; i >= 0; i--) {
> -		if (dev->states_usage[i].disable ||
> -				(no_poll && drv->states[i].flags & CPUIDLE_FLAG_POLLING))
> +		if (dev->states_usage[i].disable)
>  			continue;
>  
>  		state_idx = i;
> @@ -459,7 +457,7 @@ static int teo_select(struct cpuidle_dri
>  	 * candidate state, a shallower one needs to be found.
>  	 */
>  	if (drv->states[idx].target_residency_ns > duration_ns)
> -		idx = teo_find_shallower_state(drv, dev, idx, duration_ns, false);
> +		idx = teo_find_shallower_state(drv, dev, idx, duration_ns);
>  
>  	/*
>  	 * If the selected state's target residency is below the tick length
> @@ -487,7 +485,7 @@ end:
>  	 */
>  	if (idx > idx0 &&
>  	    drv->states[idx].target_residency_ns > delta_tick)
> -		idx = teo_find_shallower_state(drv, dev, idx, delta_tick, false);
> +		idx = teo_find_shallower_state(drv, dev, idx, delta_tick);
>  
>  out_tick:
>  	*stop_tick = false;
> 
> 
>