[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20251114130753.GA21708@pauld.westford.csb>
Date: Fri, 14 Nov 2025 08:07:53 -0500
From: Phil Auld <pauld@...hat.com>
To: linux-kernel@...r.kernel.org
Cc: linux-tip-commits@...r.kernel.org,
Frederic Weisbecker <frederic@...nel.org>,
"Peter Zijlstra (Intel)" <peterz@...radead.org>, x86@...nel.org
Subject: Re: [tip: sched/core] sched: Increase sched_tick_remote timeout
On Fri, Nov 14, 2025 at 12:19:06PM -0000 tip-bot2 for Phil Auld wrote:
> The following commit has been merged into the sched/core branch of tip:
>
> Commit-ID: 2616d12247639da40339757adc08c822147aa993
> Gitweb: https://git.kernel.org/tip/2616d12247639da40339757adc08c822147aa993
> Author: Phil Auld <pauld@...hat.com>
> AuthorDate: Thu, 11 Sep 2025 12:13:00 -04:00
> Committer: Peter Zijlstra <peterz@...radead.org>
> CommitterDate: Fri, 14 Nov 2025 13:03:06 +01:00
>
Thanks Peter!
> sched: Increase sched_tick_remote timeout
>
> Increase the sched_tick_remote WARN_ON timeout to remove false
> positives due to temporarily busy HK cpus. The suggestion
> was 30 seconds to catch really stuck remote tick processing
> but not trigger it too easily.
>
> Suggested-by: Frederic Weisbecker <frederic@...nel.org>
> Signed-off-by: Phil Auld <pauld@...hat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Acked-by: Frederic Weisbecker <frederic@...nel.org>
> Link: https://patch.msgid.link/20250911161300.437944-1-pauld@redhat.com
> ---
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 68f19aa..699db3f 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5619,7 +5619,7 @@ static void sched_tick_remote(struct work_struct *work)
> * reasonable amount of time.
> */
> u64 delta = rq_clock_task(rq) - curr->se.exec_start;
> - WARN_ON_ONCE(delta > (u64)NSEC_PER_SEC * 3);
> + WARN_ON_ONCE(delta > (u64)NSEC_PER_SEC * 30);
> }
> curr->sched_class->task_tick(rq, curr, 0);
>
>
--
Powered by blists - more mailing lists