linux-kernel - Re: [PATCH v2 03/11] PCI: Change pci_dev variable from 'bridge' to 'dev'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87346gptr7.fsf@draig.linaro.org>
Date: Fri, 14 Nov 2025 14:35:08 +0000
From: Alex Bennée <alex.bennee@...aro.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Simon Richter <Simon.Richter@...yros.de>,  Lucas De Marchi
 <lucas.demarchi@...el.com>,  Alex Deucher <alexander.deucher@....com>,
  amd-gfx@...ts.freedesktop.org,  Bjorn Helgaas <bhelgaas@...gle.com>,
  David Airlie <airlied@...il.com>,  dri-devel@...ts.freedesktop.org,
  intel-gfx@...ts.freedesktop.org,  intel-xe@...ts.freedesktop.org,  Jani
 Nikula <jani.nikula@...ux.intel.com>,  Joonas Lahtinen
 <joonas.lahtinen@...ux.intel.com>,  linux-pci@...r.kernel.org,  Rodrigo
 Vivi <rodrigo.vivi@...el.com>,  Simona Vetter <simona@...ll.ch>,  Tvrtko
 Ursulin <tursulin@...ulin.net>,  Christian König
 <christian.koenig@....com>,  Thomas Hellström
 <thomas.hellstrom@...ux.intel.com>,  Michał Winiarski
 <michal.winiarski@...el.com>,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 03/11] PCI: Change pci_dev variable from 'bridge' to
 'dev'

Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> writes:

> Upcoming fix to BAR resize will store also device BAR resource in the
> saved list. Change the pci_dev variable in the loop from 'bridge' to
> 'dev' as the former would be misleading with non-bridges in the list.
>
> This is in a separate change to reduce churn in the upcoming BAR resize
> fix.
>
> While it appears that the logic in the loop doing pci_setup_bridge() is
> altered as 'bridge' variable is no longer updated, a bridge should
> never appear more than once in the saved list so the if check can only
> match to the first entry. As such, the code with two distinct pci_dev
> variables better represents the intention of the check compared with the
> old code where bridge variable was reused for a different purpose.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Alex Bennée <alex.bennee@...aro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro