linux-kernel - Re: [PATCH v3 1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios" binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRc_y_Sf8fhFm_K8@hovoldconsulting.com>
Date: Fri, 14 Nov 2025 15:42:19 +0100
From: Johan Hovold <johan@...nel.org>
To: alejandroe1@...tab.com
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: gnss: u-blox: add "safeboot-gpios"
 binding

On Thu, Sep 11, 2025 at 02:58:28PM +0200, Alejandro Enrique via B4 Relay wrote:
> From: Alejandro Enrique <alejandroe1@...tab.com>
> 
> U-Blox 8/M8/M9 chip have a pin to start it in safeboot mode, to be
> used to recover from situations where the flash content has become
> corrupted and needs to be restored. Introduce a binding to support
> this safeboot pin.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Alejandro Enrique <alejandroe1@...tab.com>
 
> +allOf:
> +  - $ref: gnss-common.yaml#
> +  - $ref: /schemas/serial/serial-peripheral-props.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: u-blox,neo-6m
> +    then:
> +      properties:
> +        safeboot-gpios: false
> +

I don't think it's worth adding conditionals like this for an optional
gpio as it just makes the binding harder to read for no good reason (cf.
a dt checker can't verify that you're not using the wrong host pin in
your identifier either).

So I used your v1 without this (and dropped Krzysztof's tag).

>  unevaluatedProperties: false
>  
>  examples:
> @@ -65,5 +76,6 @@ examples:
>              v-bckp-supply = <&gnss_v_bckp_reg>;
>              vcc-supply = <&gnss_vcc_reg>;
>              reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> +            safeboot-gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
>          };
>      };

Johan