[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4h54pkcisk5fmevglu3qldk5fb2rgo5355vfds3wplhekfumtz@qtwtixmuw2hz>
Date: Fri, 14 Nov 2025 15:32:34 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Guopeng Zhang <zhangguopeng@...inos.cn>
Cc: tj@...nel.org, hannes@...xchg.org, shuah@...nel.org,
cgroups@...r.kernel.org, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
sebastian.chlad@...e.com, longman@...hat.com
Subject: Re: [PATCH] selftests/cgroup: conform test to TAP format output
On Fri, Nov 14, 2025 at 11:55:48AM +0800, Guopeng Zhang <zhangguopeng@...inos.cn> wrote:
> Actually, selftests are no longer just something for developers to view locally; they are now extensively
> run in CI and stable branch regression testing. Using a standardized layout means that general test runners
> and CI systems can parse the cgroup test results without any special handling.
Nice. I appreciate you took this up.
> This patch is not part of a formal, tree-wide conversion series I am running; it is an incremental step to align the
> cgroup C tests with the existing TAP usage. I started here because these tests already use ksft_test_result_*() and
> only require minor changes to generate proper TAP output.
The tests are in various state of usage, correctness and usefulness,
hence...
>
> > I'm asking to better asses whether also the scripts listed in
> > Makefile:TEST_PROGS should be converted too.
>
> I agree that having them produce TAP output would benefit tooling and CI. I did not want to mix
> that into this change, but if you and other maintainers think this direction is reasonable,
> I would be happy to follow up and convert the cgroup shell tests to TAP as well.
...I'd suggest next focus on test_cpuset_prs.sh (as discussed, it may
need more changes to adapt its output too).
Michal
Download attachment "signature.asc" of type "application/pgp-signature" (266 bytes)
Powered by blists - more mailing lists