linux-kernel - Re: [PATCH net] be2net: check wrb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251113173807.32a2ba2f@kernel.org>
Date: Thu, 13 Nov 2025 17:38:07 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ваторопин Андрей
 <a.vatoropin@...t.ru>
Cc: Ajit Khaparde <ajit.khaparde@...adcom.com>, Sriharsha Basavapatna
 <sriharsha.basavapatna@...adcom.com>, Somnath Kotur
 <somnath.kotur@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Venkata Duvvuru
 <VenkatKumar.Duvvuru@...lex.Com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "lvc-project@...uxtesting.org"
 <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] be2net: check wrb_params for NULL value

On Wed, 12 Nov 2025 09:21:04 +0000 Ваторопин Андрей wrote:
> Another way would be to pass a valid wrb_params from be_xmit(), but that
> seems to be redundant as the corresponding bit in wrb_params should have
> been already set there in advance with a call to be_xmit_workarounds().

I don't think so, or at least I don't see that for all cases..

Since there's just one caller and it has the struct handy I think 
it's better to just pass it and avoid the NULL.

BTW there are hard spaces in your commit msg, please try to fix
that for v2.
-- 
pw-bot: cr