linux-kernel - Re: [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1525f6310c331bdcd5bbcd66d2d363cec94bb7c.camel@pengutronix.de>
Date: Fri, 14 Nov 2025 16:48:39 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>, Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo
	 <shawnguo@...nel.org>, Fabio Estevam <festevam@...il.com>, Daniel Baluta
	 <daniel.baluta@....com>, Shengjiu Wang <shengjiu.wang@....com>, Frank Li
	 <Frank.Li@....com>
Cc: devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Pengutronix Kernel Team
	 <kernel@...gutronix.de>
Subject: Re: [PATCH v5 1/6] reset: imx8mp-audiomix: Drop unneeded macros

On Fr, 2025-11-14 at 05:37 -0800, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> 
> The macros defining the mask values for the EARC, EARC PHY resets,
> and the DSP RUN_STALL signal can be dropped as they are not and will
> not be used anywhere else except to set the value of the "mask" field
> from "struct imx8mp_reset_map". In this particular case, based on the
> name of the "mask" field, you can already deduce what these values are
> for, which is why defining macros for them doesn't offer any new
> information, nor does it help with the code readability.
> 
> Reviewed-by: Daniel Baluta <daniel.baluta@....com>
> Reviewed-by: Frank Li <Frank.Li@....com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp