linux-kernel - Re: [PATCH] MIPS: Fix HOTPLUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87seegr4q1.fsf@BLaptop.bootlin.com>
Date: Fri, 14 Nov 2025 16:52:54 +0100
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Benoît Monin <benoit.monin@...tlin.com>, Théo Lebrun
 <theo.lebrun@...tlin.com>, Vladimir Kondratiev
 <vladimir.kondratiev@...ileye.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, linux-mips@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] MIPS: Fix HOTPLUG_PARALLEL dependency

Thomas Bogendoerfer <tsbogend@...ha.franken.de> writes:

> On Mon, Nov 10, 2025 at 03:05:23PM +0100, Gregory CLEMENT wrote:
>> Hello Thomas,
>> 
>> > With MIPS, it is possible to have SMP enabled without HOTPLUG_CPU
>> > selected. However, in kernel/cpu.c, some code that uses
>> > HOTPLUG_PARALLEL also requires HOTPLUG_CPU to be selected. Therefore,
>> > we should fix the HOTPLUG_PARALLEL dependency to depend on
>> > HOTPLUG_CPU, not just SMP.
>> >
>> > Reported-by: kernel test robot <lkp@...el.com>
>> > Closes: https://lore.kernel.org/oe-kbuild-all/202510270120.21wA1aX1-lkp@intel.com/
>> > Signed-off-by: Gregory CLEMENT <gregory.clement@...tlin.com>
>> 
>> Do you have any comments about this fix?
>
> all good from my side, does it need to go via mips-fixes ?

This fixes a build failure that occurs only in unusual kernel
configurations, so from my point of view, it is not critical.

Gregory

>
> Thomas.
>
> -- 
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com