linux-kernel - Re: [PATCH v2 08/11] drm/xe: Remove driver side BAR release before resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gh6cx232xc6ms2d3er4724jvk2m6mjpnwd3s6ufupqrfc4iie2@h7qtm4tw3uet>
Date: Fri, 14 Nov 2025 09:58:14 -0600
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Alex Bennée <alex.bennee@...aro.org>, Simon Richter
	<Simon.Richter@...yros.de>, Alex Deucher <alexander.deucher@....com>,
	<amd-gfx@...ts.freedesktop.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "David
 Airlie" <airlied@...il.com>, <dri-devel@...ts.freedesktop.org>,
	<intel-gfx@...ts.freedesktop.org>, <intel-xe@...ts.freedesktop.org>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, <linux-pci@...r.kernel.org>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Simona Vetter <simona@...ll.ch>, Tvrtko Ursulin
	<tursulin@...ulin.net>, Christian König
	<christian.koenig@....com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, Michał Winiarski
	<michal.winiarski@...el.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 08/11] drm/xe: Remove driver side BAR release before
 resize

On Thu, Nov 13, 2025 at 06:26:25PM +0200, Ilpo Järvinen wrote:
>PCI core handles releasing device's resources and their rollback in
>case of failure of a BAR resizing operation. Releasing resource prior
>to calling pci_resize_resource() prevents PCI core from restoring the
>BARs as they were.
>
>Remove driver-side release of BARs from the xe driver.
>
>Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@...el.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>

as noted in the previous version, the conflict with drm-xe-next is
trivial: just drop the release_bars() function.

Lucas De Marchi