linux-kernel - Re: re-enable IOCB_NOWAIT writes to files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251114152840.GD30351@lst.de>
Date: Fri, 14 Nov 2025 16:28:40 +0100
From: Christoph Hellwig <hch@....de>
To: Jeff Layton <jlayton@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Christian Brauner <brauner@...nel.org>,
	Al Viro <viro@...iv.linux.org.uk>, David Sterba <dsterba@...e.com>,
	Jan Kara <jack@...e.cz>, Mike Marshall <hubcap@...ibond.com>,
	Martin Brandenburg <martin@...ibond.com>,
	Carlos Maiolino <cem@...nel.org>, Stefan Roesch <shr@...com>,
	linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org,
	gfs2@...ts.linux.dev, io-uring@...r.kernel.org,
	devel@...ts.orangefs.org, linux-unionfs@...r.kernel.org,
	linux-mtd@...ts.infradead.org, linux-xfs@...r.kernel.org,
	linux-nfs@...r.kernel.org
Subject: Re: re-enable IOCB_NOWAIT writes to files

On Fri, Nov 14, 2025 at 09:04:58AM -0500, Jeff Layton wrote:
> This all looks pretty reasonable to me. There are a few changelog and
> subject line typos, but the code changes look fine. You can add:

Please tell me about them so I can fix them. 

> As far as nfsd's usage of FMODE_NOCMTIME, it looks OK to me. That's
> implemented today by the check in file_modified_flags(), which is
> generic and should work across filesystems.

Nothing requires file_update_time / file_modified_flags are helpers
that a file system may or may not call.  I've not done an audit
if everyone actually uses them.