linux-kernel - [PATCH net] net: samsung: sxgbe: handle clk_prepare_enable() failures in sxgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251114153616.3278623-1-Pavel.Zhigulin@kaspersky.com>
Date: Fri, 14 Nov 2025 18:36:14 +0300
From: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>
To: Byungho An <bh74.an@...sung.com>
CC: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Siva Reddy <siva.kallam@...sung.com>, Girish K S
	<ks.giri@...sung.com>, Vipul Pandya <vipul.pandya@...sung.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>
Subject: [PATCH net] net: samsung: sxgbe: handle clk_prepare_enable() failures in sxgbe_open()

sxgbe_open() didn't check result of clk_prepare_enable() call.

Add missing check

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1edb9ca69e8a ("net: sxgbe: add basic framework for Samsung 10Gb ethernet driver")
Signed-off-by: Pavel Zhigulin <Pavel.Zhigulin@...persky.com>
---
 drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
index 75bad561b352..6b8e54391d7f 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
@@ -1063,7 +1063,12 @@ static int sxgbe_open(struct net_device *dev)
 	struct sxgbe_priv_data *priv = netdev_priv(dev);
 	int ret, queue_num;

-	clk_prepare_enable(priv->sxgbe_clk);
+	ret = clk_prepare_enable(priv->sxgbe_clk);
+	if (ret < 0) {
+		netdev_err(dev, "%s: Cannot enable clock (error: %d)\n",
+			   __func__, ret);
+		goto clk_error;
+	}

 	sxgbe_check_ether_addr(priv);

@@ -1195,6 +1200,7 @@ static int sxgbe_open(struct net_device *dev)
 phy_error:
 	clk_disable_unprepare(priv->sxgbe_clk);

+clk_error:
 	return ret;
 }

--
2.43.0