linux-kernel - Re: [PATCH v2 09/11] drm/i915: Remove driver side BAR release before resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gbr4vccrvzvnt2bbd6fqnqj2rdlj2ggokuu4j4bge4oxazvmfz@2lrm7bmbdr77>
Date: Fri, 14 Nov 2025 09:55:24 -0600
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Alex Bennée <alex.bennee@...aro.org>, Simon Richter
	<Simon.Richter@...yros.de>, Alex Deucher <alexander.deucher@....com>,
	<amd-gfx@...ts.freedesktop.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "David
 Airlie" <airlied@...il.com>, <dri-devel@...ts.freedesktop.org>,
	<intel-gfx@...ts.freedesktop.org>, <intel-xe@...ts.freedesktop.org>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, <linux-pci@...r.kernel.org>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Simona Vetter <simona@...ll.ch>, Tvrtko Ursulin
	<tursulin@...ulin.net>, Christian König
	<christian.koenig@....com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, Michał Winiarski
	<michal.winiarski@...el.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 09/11] drm/i915: Remove driver side BAR release before
 resize

On Thu, Nov 13, 2025 at 06:26:26PM +0200, Ilpo Järvinen wrote:
>PCI core handles releasing device's resources and their rollback in
>case of failure of a BAR resizing operation. Releasing resource prior
>to calling pci_resize_resource() prevents PCI core from restoring the
>BARs as they were.
>
>Remove driver-side release of BARs from the i915 driver.
>
>Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>

I also applied it to drm-tip from today and submitted for xe and i915
tests: https://lore.kernel.org/all/20251114154338.4161137-2-lucas.demarchi@intel.com

pass by comment... the forcewake handling in the middle of BAR resizing
is insane but it's probably because it's already very late in the probe
sequence. Moving it to early probe like was done in xe would allow it to
be simplified too.

Lucas De Marchi