linux-kernel - Re: [PATCH v3 1/2] bindings: iio: adc: Add bindings for TI ADS131M0x ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce727652-c00b-4779-97ea-0b9e4fc3477d@baylibre.com>
Date: Fri, 14 Nov 2025 10:33:59 -0600
From: David Lechner <dlechner@...libre.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>,
 Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Conor Dooley <conor.dooley@...rochip.com>, kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
 Nuno Sá <nuno.sa@...log.com>
Subject: Re: [PATCH v3 1/2] bindings: iio: adc: Add bindings for TI ADS131M0x
 ADCs

On 11/14/25 3:19 AM, Oleksij Rempel wrote:
> Add device tree bindings documentation for the Texas Instruments
> ADS131M0x analog-to-digital converters. This family includes the ADS131M02,
> ADS131M03, ADS131M04, ADS131M06, and ADS131M08 variants.
> 
> These variants differ primarily in the number of supported channels
> (2, 3, 4, 6, and 8, respectively), which requires separate compatible
> strings to validate the channel nodes.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> changes v3:
> - Make channel@ regex patterns consistent
> changes v2:
> - Rename file to ti,ads131m02.yaml and update $id.
> - Add supplies (avdd, dvdd, refin), interrupts, reset-gpios, and clock-names.
> - Make avdd-supply, dvdd-supply, and clock-names required.
> - Tighten channel validation logic for each device variant.
> - Simplify channel description and reorder datasheet list.
> - Update commit message to clarify device difference
> ---


...

> +  - if:
> +      # 32-pin devices: M06, M08
> +      # These support both XTAL/CLKIN and optional REFIN.
> +      properties:
> +        compatible:
> +          enum:
> +            - ti,ads131m06
> +            - ti,ads131m08
> +    then:
> +      properties:
> +        clock-names:
> +          description:
> +            Indicates if a crystal oscillator (XTAL) or CMOS signal is connected
> +            (CLKIN).
> +          enum: [xtal, clkin]


Usually, we want all possible properties declared at the top level and then
only limit them by the conditional statements.

This makes it easier to see what all of the possibilities are. At first I
thought clock-names had not been added.


> +        refin-supply:
> +          description: Optional external reference supply (REFIN).

refin-supply should be at the top level as well.

> +      required:
> +        - clock-names
> +